From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qa47B-0007Er-4u for qemu-devel@nongnu.org; Fri, 24 Jun 2011 06:59:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qa478-0001bg-MF for qemu-devel@nongnu.org; Fri, 24 Jun 2011 06:59:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55360) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qa477-0001bM-Ne for qemu-devel@nongnu.org; Fri, 24 Jun 2011 06:59:53 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5OAxqc3009155 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 24 Jun 2011 06:59:52 -0400 From: Gerd Hoffmann Date: Fri, 24 Jun 2011 12:59:32 +0200 Message-Id: <1308913175-10454-11-git-send-email-kraxel@redhat.com> In-Reply-To: <1308913175-10454-1-git-send-email-kraxel@redhat.com> References: <1308913175-10454-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH 10/13] usb-bus: Don't allow speed mismatch while attaching devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Hans de Goede , Gerd Hoffmann From: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb-bus.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index fc72018..2abce12 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -200,6 +200,11 @@ static int do_attach(USBDevice *dev) } else { port = QTAILQ_FIRST(&bus->free); } + if (!(port->speedmask & dev->speedmask)) { + error_report("Warning: speed mismatch trying to attach usb device %s to bus %s\n", + dev->product_desc, bus->qbus.name); + return -1; + } dev->attached++; QTAILQ_REMOVE(&bus->free, port, next); -- 1.7.1