qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	Juan Quintela <quintela@redhat.com>
Subject: [Qemu-devel] [PATCH 12/13] exec: last_first_tb was only used in !ONLY_USER case
Date: Fri, 24 Jun 2011 17:56:48 +0100	[thread overview]
Message-ID: <1308934609-20824-13-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1308934609-20824-1-git-send-email-stefanha@linux.vnet.ibm.com>

From: Juan Quintela <quintela@redhat.com>

Once there, use a better variable name.

Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 exec.c |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/exec.c b/exec.c
index b03b5be..7236281 100644
--- a/exec.c
+++ b/exec.c
@@ -1208,12 +1208,16 @@ static inline void tb_alloc_page(TranslationBlock *tb,
                                  unsigned int n, tb_page_addr_t page_addr)
 {
     PageDesc *p;
-    TranslationBlock *last_first_tb;
+#ifndef CONFIG_USER_ONLY
+    bool page_already_protected;
+#endif
 
     tb->page_addr[n] = page_addr;
     p = page_find_alloc(page_addr >> TARGET_PAGE_BITS, 1);
     tb->page_next[n] = p->first_tb;
-    last_first_tb = p->first_tb;
+#ifndef CONFIG_USER_ONLY
+    page_already_protected = p->first_tb != NULL;
+#endif
     p->first_tb = (TranslationBlock *)((long)tb | n);
     invalidate_page_bitmap(p);
 
@@ -1249,7 +1253,7 @@ static inline void tb_alloc_page(TranslationBlock *tb,
     /* if some code is already present, then the pages are already
        protected. So we handle the case where only the first TB is
        allocated in a physical page */
-    if (!last_first_tb) {
+    if (!page_already_protected) {
         tlb_protect_code(page_addr);
     }
 #endif
-- 
1.7.5.4

  parent reply	other threads:[~2011-06-24 16:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-24 16:56 [Qemu-devel] [PULL 00/13] Trivial patches for June 16 to June 24 2011 Stefan Hajnoczi
2011-06-24 16:56 ` [Qemu-devel] [PATCH 01/13] configure: Don't create symlinks to nonexistent targets Stefan Hajnoczi
2011-06-24 16:56 ` [Qemu-devel] [PATCH 02/13] Align dummy display to fixed-size active console Stefan Hajnoczi
2011-06-24 16:56 ` [Qemu-devel] [PATCH 03/13] sheepdog: qemu_bh_new() can't return null pointer, drop check Stefan Hajnoczi
2011-06-24 16:56 ` [Qemu-devel] [PATCH 04/13] Strip trailing '\n' from error_report()'s first argument Stefan Hajnoczi
2011-06-24 16:56 ` [Qemu-devel] [PATCH 05/13] qemu-img: Don't prepend qemu-img to error messages twice Stefan Hajnoczi
2011-06-24 16:56 ` [Qemu-devel] [PATCH 06/13] Spell "unkown" correctly in error_report() arguments Stefan Hajnoczi
2011-06-24 16:56 ` [Qemu-devel] [PATCH 07/13] blockdev: Put space after comma in error message Stefan Hajnoczi
2011-06-24 16:56 ` [Qemu-devel] [PATCH 08/13] MAINTAINERS: Fix typo in email address Stefan Hajnoczi
2011-06-24 16:56 ` [Qemu-devel] [PATCH 09/13] Fix comment typos in hw/armv7m.c Stefan Hajnoczi
2011-06-24 16:56 ` [Qemu-devel] [PATCH 10/13] Do not include compatfd for WIN32 Stefan Hajnoczi
2011-06-24 16:56 ` [Qemu-devel] [PATCH 11/13] w32: Remove redundant definitions of PRI*64 Stefan Hajnoczi
2011-06-24 16:56 ` Stefan Hajnoczi [this message]
2011-06-24 16:56 ` [Qemu-devel] [PATCH 13/13] qemu-kvm: fix pulseaudio detection in configure Stefan Hajnoczi
2011-06-27 19:54 ` [Qemu-devel] [PULL 00/13] Trivial patches for June 16 to June 24 2011 Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1308934609-20824-13-git-send-email-stefanha@linux.vnet.ibm.com \
    --to=stefanha@gmail.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).