From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qa9hW-0004Ye-2S for qemu-devel@nongnu.org; Fri, 24 Jun 2011 12:57:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qa9hU-0001Yq-1I for qemu-devel@nongnu.org; Fri, 24 Jun 2011 12:57:49 -0400 Received: from mail-fx0-f45.google.com ([209.85.161.45]:64284) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qa9hT-0001QQ-I1 for qemu-devel@nongnu.org; Fri, 24 Jun 2011 12:57:47 -0400 Received: by mail-fx0-f45.google.com with SMTP id 12so94133fxg.4 for ; Fri, 24 Jun 2011 09:57:47 -0700 (PDT) From: Stefan Hajnoczi Date: Fri, 24 Jun 2011 17:56:48 +0100 Message-Id: <1308934609-20824-13-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1308934609-20824-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1308934609-20824-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 12/13] exec: last_first_tb was only used in !ONLY_USER case List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Stefan Hajnoczi , Juan Quintela From: Juan Quintela Once there, use a better variable name. Signed-off-by: Juan Quintela Reviewed-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- exec.c | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/exec.c b/exec.c index b03b5be..7236281 100644 --- a/exec.c +++ b/exec.c @@ -1208,12 +1208,16 @@ static inline void tb_alloc_page(TranslationBlock *tb, unsigned int n, tb_page_addr_t page_addr) { PageDesc *p; - TranslationBlock *last_first_tb; +#ifndef CONFIG_USER_ONLY + bool page_already_protected; +#endif tb->page_addr[n] = page_addr; p = page_find_alloc(page_addr >> TARGET_PAGE_BITS, 1); tb->page_next[n] = p->first_tb; - last_first_tb = p->first_tb; +#ifndef CONFIG_USER_ONLY + page_already_protected = p->first_tb != NULL; +#endif p->first_tb = (TranslationBlock *)((long)tb | n); invalidate_page_bitmap(p); @@ -1249,7 +1253,7 @@ static inline void tb_alloc_page(TranslationBlock *tb, /* if some code is already present, then the pages are already protected. So we handle the case where only the first TB is allocated in a physical page */ - if (!last_first_tb) { + if (!page_already_protected) { tlb_protect_code(page_addr); } #endif -- 1.7.5.4