From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qa9hD-0004R7-IF for qemu-devel@nongnu.org; Fri, 24 Jun 2011 12:57:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qa9hB-0001UG-9O for qemu-devel@nongnu.org; Fri, 24 Jun 2011 12:57:30 -0400 Received: from mail-fx0-f45.google.com ([209.85.161.45]:64284) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qa9hA-0001QQ-Ma for qemu-devel@nongnu.org; Fri, 24 Jun 2011 12:57:28 -0400 Received: by mail-fx0-f45.google.com with SMTP id 12so94133fxg.4 for ; Fri, 24 Jun 2011 09:57:28 -0700 (PDT) From: Stefan Hajnoczi Date: Fri, 24 Jun 2011 17:56:37 +0100 Message-Id: <1308934609-20824-2-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1308934609-20824-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1308934609-20824-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 01/13] configure: Don't create symlinks to nonexistent targets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Anthony Liguori , Stefan Hajnoczi From: Peter Maydell When we create the symlinks to source tree files, don't create them if the file is not actually present in the source tree; this will happen if the file is in a git submodule that wasn't checked out. This also avoids the odd effect where an in-source-tree configure will end up creating the missing file as a symlink to itself. Signed-off-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- configure | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 856b41e..4fa9a57 100755 --- a/configure +++ b/configure @@ -3479,7 +3479,9 @@ for bios_file in $source_path/pc-bios/*.bin $source_path/pc-bios/*.rom $source_p done mkdir -p $DIRS for f in $FILES ; do - test -e $f || symlink $source_path/$f $f + if [ -e "$source_path/$f" ] && ! [ -e "$f" ]; then + symlink "$source_path/$f" "$f" + fi done # temporary config to build submodules -- 1.7.5.4