From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qb2pR-0000Og-2o for qemu-devel@nongnu.org; Sun, 26 Jun 2011 23:49:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qb2pP-0007WG-D1 for qemu-devel@nongnu.org; Sun, 26 Jun 2011 23:49:40 -0400 Received: from mail-iw0-f173.google.com ([209.85.214.173]:59042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qb2pP-0007Vj-25 for qemu-devel@nongnu.org; Sun, 26 Jun 2011 23:49:39 -0400 Received: by mail-iw0-f173.google.com with SMTP id 3so4689050iwn.4 for ; Sun, 26 Jun 2011 20:49:38 -0700 (PDT) From: Fam Zheng Date: Mon, 27 Jun 2011 11:48:29 +0800 Message-Id: <1309146518-8998-4-git-send-email-famcool@gmail.com> In-Reply-To: <1309146518-8998-1-git-send-email-famcool@gmail.com> References: <1309146518-8998-1-git-send-email-famcool@gmail.com> Subject: [Qemu-devel] [PATCH v3 03/12] VMDK: probe for monolithicFlat images List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, Fam Zheng , hch@lst.de, stefanha@gmail.com Probe as the same behavior as VMware does. Recognize image as monolithicFlat descriptor file when the file is text and the first effective line (not '#' leaded comment or space line) is either 'version=1' or 'version=2'. No space or upper case charactors accepted. Signed-off-by: Fam Zheng --- block/vmdk.c | 38 ++++++++++++++++++++++++++++++++++++-- 1 files changed, 36 insertions(+), 2 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 0540ec5..0517fdf 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -102,10 +102,44 @@ static int vmdk_probe(const uint8_t *buf, int buf_size, const char *filename) return 0; magic = be32_to_cpu(*(uint32_t *)buf); if (magic == VMDK3_MAGIC || - magic == VMDK4_MAGIC) + magic == VMDK4_MAGIC) { return 100; - else + } else { + const char *p = (const char *)buf; + const char *end = p + buf_size; + while (p < end) { + if (*p == '#') { + /* skip comment line */ + while (p < end && *p != '\n') { + p++; + } + p++; + continue; + } + if (*p == ' ') { + while (p < end && *p == ' ') { + p++; + } + /* skip '\r' if windows line endings used. */ + if (p < end && *p == '\r') { + p++; + } + /* only accept blank lines before 'version=' line */ + if (p == end || *p != '\n') { + return 0; + } + p++; + continue; + } + if (strncmp("version=1\n", p, strlen("version=1\n")) == 0 || + strncmp("version=1\r\n", p, strlen("version=1\r\n")) == 0 || + strncmp("version=2\n", p, strlen("version=2\n")) == 0 || + strncmp("version=2\r\n", p, strlen("version=2\r\n")) == 0) { + return 100; + } + } return 0; + } } #define CHECK_CID 1