From: Alon Levy <alevy@redhat.com>
To: qemu-devel@nongnu.org
Cc: yhalperi@redhat.com, kraxel@redhat.com
Subject: [Qemu-devel] [PATCHv3] async io: suggested fixes
Date: Wed, 29 Jun 2011 13:57:07 +0200 [thread overview]
Message-ID: <1309348641-20061-2-git-send-email-alevy@redhat.com> (raw)
In-Reply-To: <1309348641-20061-1-git-send-email-alevy@redhat.com>
---
hw/qxl.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index a26fb2a..89e452e 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1178,6 +1178,7 @@ static void ioport_write(void *opaque, uint32_t addr, uint32_t val)
case QXL_IO_MEMSLOT_ADD_ASYNC:
PANIC_ON(val >= NUM_MEMSLOTS);
PANIC_ON(d->guest_slots[val].active);
+ dprint(d, 1, "QXL_IO_MEMSLOT_ADD_ASYNC %d\n", val);
d->guest_slots[val].slot = d->ram->mem_slot;
async = qemu_mallocz(sizeof(*async));
qxl_add_memslot(d, val, 0, &async->memslot);
@@ -1715,7 +1716,7 @@ static PCIDeviceInfo qxl_info_primary = {
.qdev.props = (Property[]) {
DEFINE_PROP_UINT32("ram_size", PCIQXLDevice, vga.vram_size, 64 * 1024 * 1024),
DEFINE_PROP_UINT32("vram_size", PCIQXLDevice, vram_size, 64 * 1024 * 1024),
- DEFINE_PROP_UINT32("revision", PCIQXLDevice, revision, 3),
+ DEFINE_PROP_UINT32("revision", PCIQXLDevice, revision, QXL_REVISION_STABLE_V10),
DEFINE_PROP_UINT32("debug", PCIQXLDevice, debug, 0),
DEFINE_PROP_UINT32("guestdebug", PCIQXLDevice, guestdebug, 0),
DEFINE_PROP_UINT32("cmdlog", PCIQXLDevice, cmdlog, 0),
@@ -1735,7 +1736,7 @@ static PCIDeviceInfo qxl_info_secondary = {
.qdev.props = (Property[]) {
DEFINE_PROP_UINT32("ram_size", PCIQXLDevice, vga.vram_size, 64 * 1024 * 1024),
DEFINE_PROP_UINT32("vram_size", PCIQXLDevice, vram_size, 64 * 1024 * 1024),
- DEFINE_PROP_UINT32("revision", PCIQXLDevice, revision, 3),
+ DEFINE_PROP_UINT32("revision", PCIQXLDevice, revision, QXL_REVISION_STABLE_V10),
DEFINE_PROP_UINT32("debug", PCIQXLDevice, debug, 0),
DEFINE_PROP_UINT32("guestdebug", PCIQXLDevice, guestdebug, 0),
DEFINE_PROP_UINT32("cmdlog", PCIQXLDevice, cmdlog, 0),
--
1.7.5.4
next prev parent reply other threads:[~2011-06-29 11:57 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 11:57 [Qemu-devel] [PATCHv3] qxl S3&S4 (suspend and hibernate) support Alon Levy
2011-06-29 11:57 ` Alon Levy [this message]
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] async thread fix - handle EAGAIN/EINTR, remove fprintf Alon Levy
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl: use track_lock instead of wlock for guest_surfaces Alon Levy
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl: add mode to debugprint on destroy primary Alon Levy
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl: allow QXL_IO_LOG also in vga Alon Levy
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl: abort on panic instead of exit Alon Levy
2011-06-29 12:44 ` Gerd Hoffmann
2011-06-29 14:24 ` Alon Levy
2011-06-29 14:34 ` Gerd Hoffmann
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl-logger: add timestamp to command log Alon Levy
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl: update and add debug prints Alon Levy
2011-06-29 13:01 ` Gerd Hoffmann
2011-06-29 14:24 ` Alon Levy
2011-06-29 14:36 ` Gerd Hoffmann
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl: add dev id to guest prints Alon Levy
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl: add io_port_to_string Alon Levy
2011-06-29 13:03 ` Gerd Hoffmann
2011-06-29 14:25 ` Alon Levy
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl: update revision to QXL_REVISION_STABLE_V10 Alon Levy
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3&S4 support Alon Levy
2011-06-29 13:06 ` Gerd Hoffmann
2011-06-29 14:27 ` Alon Levy
2011-06-29 14:50 ` Gerd Hoffmann
2011-06-29 18:22 ` Alon Levy
2011-06-29 14:45 ` Alon Levy
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl: move to UNDEFINED on DESTROY_ALL_SURFACES{, _ASYNC} Alon Levy
2011-06-29 13:09 ` Gerd Hoffmann
2011-06-29 14:29 ` Alon Levy
2011-06-29 15:00 ` Gerd Hoffmann
2011-06-29 18:28 ` Alon Levy
2011-06-30 7:16 ` Gerd Hoffmann
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl: only disallow specific io's in vga mode Alon Levy
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] (alon-local) symlink bios out of tree Alon Levy
2011-06-29 13:11 ` Gerd Hoffmann
2011-06-29 14:31 ` Alon Levy
2011-06-29 15:01 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309348641-20061-2-git-send-email-alevy@redhat.com \
--to=alevy@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yhalperi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).