From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Riku Voipio" <riku.voipio@iki.fi>,
"Juha Riihimäki" <juha.riihimaki@nokia.com>,
patches@linaro.org
Subject: [Qemu-devel] [PATCH 2/3] hw/omap_gpio.c: Don't complain about some writes to r/o registers
Date: Wed, 29 Jun 2011 19:53:10 +0100 [thread overview]
Message-ID: <1309373591-30380-3-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1309373591-30380-1-git-send-email-peter.maydell@linaro.org>
Don't complain about some writes to r/o OMAP2 GPIO registers, because the
kernel will do them anyway.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/omap_gpio.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/omap_gpio.c b/hw/omap_gpio.c
index 478f7d9..b53b13b 100644
--- a/hw/omap_gpio.c
+++ b/hw/omap_gpio.c
@@ -385,7 +385,7 @@ static void omap2_gpio_module_write(void *opaque, target_phys_addr_t addr,
case 0x00: /* GPIO_REVISION */
case 0x14: /* GPIO_SYSSTATUS */
case 0x38: /* GPIO_DATAIN */
- OMAP_RO_REG(addr);
+ /* read-only, ignore quietly */
break;
case 0x10: /* GPIO_SYSCONFIG */
@@ -531,7 +531,7 @@ static void omap2_gpio_module_writep(void *opaque, target_phys_addr_t addr,
case 0x00: /* GPIO_REVISION */
case 0x14: /* GPIO_SYSSTATUS */
case 0x38: /* GPIO_DATAIN */
- OMAP_RO_REG(addr);
+ /* read-only, ignore quietly */
break;
case 0x10: /* GPIO_SYSCONFIG */
--
1.7.1
next prev parent reply other threads:[~2011-06-29 18:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 18:53 [Qemu-devel] [PATCH 0/3] omap_gpio: convert to qdev Peter Maydell
2011-06-29 18:53 ` [Qemu-devel] [PATCH 1/3] hw/omap_l4.c: Add helper function omap_l4_base Peter Maydell
2011-06-29 18:53 ` Peter Maydell [this message]
2011-06-29 20:07 ` [Qemu-devel] [PATCH 2/3] hw/omap_gpio.c: Don't complain about some writes to r/o registers Edgar E. Iglesias
2011-06-29 20:39 ` Peter Maydell
2011-06-29 20:49 ` Edgar E. Iglesias
2011-06-29 18:53 ` [Qemu-devel] [PATCH 3/3] hw/omap_gpio.c: Convert to qdev Peter Maydell
2011-07-04 22:39 ` andrzej zaborowski
2011-07-05 13:19 ` Peter Maydell
2011-07-07 15:29 ` andrzej zaborowski
2011-07-07 16:00 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309373591-30380-3-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=juha.riihimaki@nokia.com \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).