qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, armbru@redhat.com
Subject: [Qemu-devel] [PATCH 2/3] block: drive_init(): Simplify interface type setting
Date: Thu, 30 Jun 2011 15:33:02 -0300	[thread overview]
Message-ID: <1309458783-12661-3-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1309458783-12661-1-git-send-email-lcapitulino@redhat.com>

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 blockdev.c |   11 ++++-------
 1 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/blockdev.c b/blockdev.c
index 27bf68a..0a90ae8 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -241,13 +241,6 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi)
 
     translation = BIOS_ATA_TRANSLATION_AUTO;
 
-    if (default_to_scsi) {
-        type = IF_SCSI;
-        pstrcpy(devname, sizeof(devname), "scsi");
-    } else {
-        type = IF_IDE;
-        pstrcpy(devname, sizeof(devname), "ide");
-    }
     media = MEDIA_DISK;
 
     /* extract parameters */
@@ -273,7 +266,11 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi)
             error_report("unsupported bus type '%s'", buf);
             return NULL;
 	    }
+    } else {
+        type = default_to_scsi ? IF_SCSI : IF_IDE;
+        pstrcpy(devname, sizeof(devname), if_name[type]);
     }
+
     max_devs = if_max_devs[type];
 
     if (cyls || heads || secs) {
-- 
1.7.6.49.g033c2

  parent reply	other threads:[~2011-06-30 18:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-30 18:33 [Qemu-devel] [PATCH 0/3]: block: Small drive_init() improvements Luiz Capitulino
2011-06-30 18:33 ` [Qemu-devel] [PATCH 1/3] block: drive_init(): Fix indentation Luiz Capitulino
2011-06-30 20:32   ` Stefan Weil
2011-07-01  7:16   ` Markus Armbruster
2011-07-01 13:24     ` Luiz Capitulino
2011-06-30 18:33 ` Luiz Capitulino [this message]
2011-07-01  7:18   ` [Qemu-devel] [PATCH 2/3] block: drive_init(): Simplify interface type setting Markus Armbruster
2011-06-30 18:33 ` [Qemu-devel] [PATCH 3/3] block: drive_init(): Improve CHS setting error message Luiz Capitulino
2011-07-01  7:21   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1309458783-12661-3-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).