qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, armbru@redhat.com
Subject: [Qemu-devel] [PATCH 3/3] block: drive_init(): Improve CHS setting error message
Date: Thu, 30 Jun 2011 15:33:03 -0300	[thread overview]
Message-ID: <1309458783-12661-4-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1309458783-12661-1-git-send-email-lcapitulino@redhat.com>

The current media doesn't clearly say the error cause.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 blockdev.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/blockdev.c b/blockdev.c
index 0a90ae8..2dbdd1b 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -311,7 +311,7 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi)
 	        media = MEDIA_DISK;
 	    } else if (!strcmp(buf, "cdrom")) {
             if (cyls || secs || heads) {
-                error_report("'%s' invalid physical CHS format", buf);
+                error_report("CHS can't be set for CDROM media '%s'", buf);
 	            return NULL;
             }
 	        media = MEDIA_CDROM;
-- 
1.7.6.49.g033c2

  parent reply	other threads:[~2011-06-30 18:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-30 18:33 [Qemu-devel] [PATCH 0/3]: block: Small drive_init() improvements Luiz Capitulino
2011-06-30 18:33 ` [Qemu-devel] [PATCH 1/3] block: drive_init(): Fix indentation Luiz Capitulino
2011-06-30 20:32   ` Stefan Weil
2011-07-01  7:16   ` Markus Armbruster
2011-07-01 13:24     ` Luiz Capitulino
2011-06-30 18:33 ` [Qemu-devel] [PATCH 2/3] block: drive_init(): Simplify interface type setting Luiz Capitulino
2011-07-01  7:18   ` Markus Armbruster
2011-06-30 18:33 ` Luiz Capitulino [this message]
2011-07-01  7:21   ` [Qemu-devel] [PATCH 3/3] block: drive_init(): Improve CHS setting error message Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1309458783-12661-4-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).