From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcM3A-0001pY-Sk for qemu-devel@nongnu.org; Thu, 30 Jun 2011 14:33:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QcM37-0007zY-MP for qemu-devel@nongnu.org; Thu, 30 Jun 2011 14:33:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30250) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcM36-0007z3-RE for qemu-devel@nongnu.org; Thu, 30 Jun 2011 14:33:13 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5UIXBW8014357 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 30 Jun 2011 14:33:11 -0400 From: Luiz Capitulino Date: Thu, 30 Jun 2011 15:33:03 -0300 Message-Id: <1309458783-12661-4-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1309458783-12661-1-git-send-email-lcapitulino@redhat.com> References: <1309458783-12661-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 3/3] block: drive_init(): Improve CHS setting error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com The current media doesn't clearly say the error cause. Signed-off-by: Luiz Capitulino --- blockdev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/blockdev.c b/blockdev.c index 0a90ae8..2dbdd1b 100644 --- a/blockdev.c +++ b/blockdev.c @@ -311,7 +311,7 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi) media = MEDIA_DISK; } else if (!strcmp(buf, "cdrom")) { if (cyls || secs || heads) { - error_report("'%s' invalid physical CHS format", buf); + error_report("CHS can't be set for CDROM media '%s'", buf); return NULL; } media = MEDIA_CDROM; -- 1.7.6.49.g033c2