qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] PCI: how handle multifunction / compound devices best?
Date: Fri,  1 Jul 2011 13:27:24 +0200	[thread overview]
Message-ID: <1309519646-3206-1-git-send-email-kraxel@redhat.com> (raw)

  Hi folks,

I'm still looking for a sane way to handle multifunction pci devices,
specifically a EHCI USB controller with UHCI companion controllers.

Here comes a small (incomplete[1]) two patch series to make the issue
more clear.  The first patch adds a function which creates all devices
with the properties set as needed.  The second patch adds a '-usb2'
switch to windup this in a user-friendly way.

Adding a -usb2 switch sucks though.  I'd prefer to have some way to
create such devices via -device, but without asking the user to create
all functions individually on the command line, i.e. have something
along the lines of ...

 qemu -device ich9-usb,slot=08

... instead of ...

 qemu \
  -device ich9-usb-ehci1,addr=08.7,multifunction=on,id=ehci \
  -device ich9-usb-uhci1,addr=08.0,multifunction=on,masterbus=ehci.0,firstport=0 \
  -device ich9-usb-uhci2,addr=08.1,multifunction=on,masterbus=ehci.0,firstport=2 \
  -device ich9-usb-uhci3,addr=08.2,multifunction=on,masterbus=ehci.0,firstport=4

Suggestions?

cheers,
  Gerd

[1] full series @ http://www.kraxel.org/cgit/qemu/log/?h=usb.18

Gerd Hoffmann (2):
  usb: add ich9_ehci_with_companion_init()
  usb: windup ich9_ehci_with_companion_init via -usb2 switch.

 hw/pc_piix.c    |   14 ++++++++++----
 hw/usb-ehci.c   |   49 +++++++++++++++++++++++++++++++++++++++++++++++++
 hw/usb.h        |    3 +++
 qemu-options.hx |   13 +++++++++++--
 vl.c            |    3 +++
 5 files changed, 76 insertions(+), 6 deletions(-)

             reply	other threads:[~2011-07-01 11:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-01 11:27 Gerd Hoffmann [this message]
2011-07-01 11:27 ` [Qemu-devel] [PATCH 1/2] usb: add ich9_ehci_with_companion_init() Gerd Hoffmann
2011-07-01 11:27 ` [Qemu-devel] [PATCH 2/2] usb: windup ich9_ehci_with_companion_init via -usb2 switch Gerd Hoffmann
2011-07-01 12:19 ` [Qemu-devel] PCI: how handle multifunction / compound devices best? Anthony Liguori
2011-07-04 15:19   ` Markus Armbruster
2011-07-04 16:09 ` Markus Armbruster
2011-07-05  7:41   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1309519646-3206-1-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).