* [Qemu-devel] [PATCH] esp: correctly fill bus id with requested lun
@ 2011-07-02 15:23 Hervé Poussineau
2011-07-02 20:38 ` Blue Swirl
2011-07-21 23:22 ` Artyom Tarasenko
0 siblings, 2 replies; 3+ messages in thread
From: Hervé Poussineau @ 2011-07-02 15:23 UTC (permalink / raw)
To: qemu-devel; +Cc: Hervé Poussineau
This bug showed up after 1455084ea2c48abf23c4e4e15e378ee43457f381, and
may be seen only on operating systems *not* using DMA to give commands
to SCSI adapter.
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
hw/esp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/esp.c b/hw/esp.c
index 6d3f5d2..8e95672 100644
--- a/hw/esp.c
+++ b/hw/esp.c
@@ -211,7 +211,7 @@ static uint32_t get_cmd(ESPState *s, uint8_t *buf)
} else {
dmalen = s->ti_size;
memcpy(buf, s->ti_buf, dmalen);
- buf[0] = 0;
+ buf[0] = buf[2] >> 5;
}
DPRINTF("get_cmd: len %d target %d\n", dmalen, target);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] esp: correctly fill bus id with requested lun
2011-07-02 15:23 [Qemu-devel] [PATCH] esp: correctly fill bus id with requested lun Hervé Poussineau
@ 2011-07-02 20:38 ` Blue Swirl
2011-07-21 23:22 ` Artyom Tarasenko
1 sibling, 0 replies; 3+ messages in thread
From: Blue Swirl @ 2011-07-02 20:38 UTC (permalink / raw)
To: Hervé Poussineau; +Cc: qemu-devel
Thanks, applied.
2011/7/2 Hervé Poussineau <hpoussin@reactos.org>:
> This bug showed up after 1455084ea2c48abf23c4e4e15e378ee43457f381, and
> may be seen only on operating systems *not* using DMA to give commands
> to SCSI adapter.
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
> hw/esp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/esp.c b/hw/esp.c
> index 6d3f5d2..8e95672 100644
> --- a/hw/esp.c
> +++ b/hw/esp.c
> @@ -211,7 +211,7 @@ static uint32_t get_cmd(ESPState *s, uint8_t *buf)
> } else {
> dmalen = s->ti_size;
> memcpy(buf, s->ti_buf, dmalen);
> - buf[0] = 0;
> + buf[0] = buf[2] >> 5;
> }
> DPRINTF("get_cmd: len %d target %d\n", dmalen, target);
>
> --
> 1.7.5.4
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] esp: correctly fill bus id with requested lun
2011-07-02 15:23 [Qemu-devel] [PATCH] esp: correctly fill bus id with requested lun Hervé Poussineau
2011-07-02 20:38 ` Blue Swirl
@ 2011-07-21 23:22 ` Artyom Tarasenko
1 sibling, 0 replies; 3+ messages in thread
From: Artyom Tarasenko @ 2011-07-21 23:22 UTC (permalink / raw)
To: Hervé Poussineau; +Cc: qemu-devel
2011/7/2 Hervé Poussineau <hpoussin@reactos.org>:
> This bug showed up after 1455084ea2c48abf23c4e4e15e378ee43457f381, and
> may be seen only on operating systems *not* using DMA to give commands
> to SCSI adapter.
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
> hw/esp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/esp.c b/hw/esp.c
> index 6d3f5d2..8e95672 100644
> --- a/hw/esp.c
> +++ b/hw/esp.c
> @@ -211,7 +211,7 @@ static uint32_t get_cmd(ESPState *s, uint8_t *buf)
> } else {
> dmalen = s->ti_size;
> memcpy(buf, s->ti_buf, dmalen);
> - buf[0] = 0;
> + buf[0] = buf[2] >> 5;
why this byte needs to be overwritten? Doesn't ti_buf have a bus id?
> }
> DPRINTF("get_cmd: len %d target %d\n", dmalen, target);
>
> --
> 1.7.5.4
>
>
>
--
Regards,
Artyom Tarasenko
solaris/sparc under qemu blog: http://tyom.blogspot.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-07-21 23:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-02 15:23 [Qemu-devel] [PATCH] esp: correctly fill bus id with requested lun Hervé Poussineau
2011-07-02 20:38 ` Blue Swirl
2011-07-21 23:22 ` Artyom Tarasenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).