From: Fam Zheng <famcool@gmail.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Fam Zheng <famcool@gmail.com>,
hch@lst.de, stefanha@gmail.com
Subject: [Qemu-devel] [PATCH v7 07/12] VMDK: move 'static' cid_update flag to bs field
Date: Sun, 3 Jul 2011 23:06:47 +0800 [thread overview]
Message-ID: <1309705612-27079-8-git-send-email-famcool@gmail.com> (raw)
In-Reply-To: <1309705612-27079-1-git-send-email-famcool@gmail.com>
Cid_update is the flag for updating CID on first write after opening the
image. This should be per image open rather than per program life cycle,
so change it from static var of vmdk_write to a field in BDRVVmdkState.
Signed-off-by: Fam Zheng <famcool@gmail.com>
---
block/vmdk.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index fbc8af5..196419b 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -82,6 +82,7 @@ typedef struct VmdkExtent {
typedef struct BDRVVmdkState {
int desc_offset;
+ bool cid_updated;
uint32_t parent_cid;
int num_extents;
/* Extent array with num_extents entries, ascend ordered by address */
@@ -852,7 +853,6 @@ static int vmdk_write(BlockDriverState *bs, int64_t sector_num,
int n;
int64_t index_in_cluster;
uint64_t cluster_offset;
- static int cid_update = 0;
VmdkMetaData m_data;
if (sector_num > bs->total_sectors) {
@@ -899,9 +899,9 @@ static int vmdk_write(BlockDriverState *bs, int64_t sector_num,
buf += n * 512;
// update CID on the first write every time the virtual disk is opened
- if (!cid_update) {
+ if (!s->cid_updated) {
vmdk_write_cid(bs, time(NULL));
- cid_update++;
+ s->cid_updated = true;
}
}
return 0;
next prev parent reply other threads:[~2011-07-03 15:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-03 15:06 [Qemu-devel] [PATCH v7 00/12] Adding VMDK monolithic flat support Fam Zheng
2011-07-03 15:06 ` [Qemu-devel] [PATCH v7 01/12] VMDK: introduce VmdkExtent Fam Zheng
2011-07-03 15:06 ` [Qemu-devel] [PATCH v7 02/12] VMDK: bugfix, align offset to cluster in get_whole_cluster Fam Zheng
2011-07-03 15:06 ` [Qemu-devel] [PATCH v7 03/12] VMDK: probe for monolithicFlat images Fam Zheng
2011-07-04 10:38 ` Kevin Wolf
2011-07-03 15:06 ` [Qemu-devel] [PATCH v7 04/12] VMDK: separate vmdk_open by format version Fam Zheng
2011-07-03 15:06 ` [Qemu-devel] [PATCH v7 05/12] VMDK: add field BDRVVmdkState.desc_offset Fam Zheng
2011-07-03 15:06 ` [Qemu-devel] [PATCH v7 06/12] VMDK: flush multiple extents Fam Zheng
2011-07-03 15:06 ` Fam Zheng [this message]
2011-07-03 15:06 ` [Qemu-devel] [PATCH v7 08/12] VMDK: change get_cluster_offset return type Fam Zheng
2011-07-03 15:06 ` [Qemu-devel] [PATCH v7 09/12] VMDK: open/read/write for monolithicFlat image Fam Zheng
2011-07-03 15:06 ` [Qemu-devel] [PATCH v7 10/12] VMDK: create different subformats Fam Zheng
2011-07-03 15:06 ` [Qemu-devel] [PATCH v7 11/12] VMDK: fix coding style Fam Zheng
2011-07-03 15:06 ` [Qemu-devel] [PATCH v7 12/12] block: add bdrv_get_allocated_file_size() operation Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309705612-27079-8-git-send-email-famcool@gmail.com \
--to=famcool@gmail.com \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).