From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QeSwF-0007U4-OS for qemu-devel@nongnu.org; Wed, 06 Jul 2011 10:18:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QeSwE-0001IF-7s for qemu-devel@nongnu.org; Wed, 06 Jul 2011 10:18:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30088) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QeSwD-0001I4-JN for qemu-devel@nongnu.org; Wed, 06 Jul 2011 10:18:49 -0400 From: Kevin Wolf Date: Wed, 6 Jul 2011 16:21:29 +0200 Message-Id: <1309962089-7328-9-git-send-email-kwolf@redhat.com> In-Reply-To: <1309962089-7328-1-git-send-email-kwolf@redhat.com> References: <1309962089-7328-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 8/8] ide: Initialise buffers with zeros List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org Just in case there's still a way how a guest can read out buffers when it's not supposed to, let's zero the buffers during initialisation so that we don't leak information to the guest. Signed-off-by: Kevin Wolf Reviewed-by: Markus Armbruster --- hw/ide/core.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index a29ae9f..d145b19 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -1789,9 +1789,13 @@ static void ide_init1(IDEBus *bus, int unit) s->unit = unit; s->drive_serial = drive_serial++; /* we need at least 2k alignment for accessing CDROMs using O_DIRECT */ - s->io_buffer = qemu_memalign(2048, IDE_DMA_BUF_SECTORS*512 + 4); s->io_buffer_total_len = IDE_DMA_BUF_SECTORS*512 + 4; + s->io_buffer = qemu_memalign(2048, s->io_buffer_total_len); + memset(s->io_buffer, 0, s->io_buffer_total_len); + s->smart_selftest_data = qemu_blockalign(s->bs, 512); + memset(s->smart_selftest_data, 0, 512); + s->sector_write_timer = qemu_new_timer_ns(vm_clock, ide_sector_write_timer_cb, s); } -- 1.7.6