From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qerx2-0003P1-JX for qemu-devel@nongnu.org; Thu, 07 Jul 2011 13:01:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QernM-00081r-8A for qemu-devel@nongnu.org; Thu, 07 Jul 2011 12:51:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QernL-00081i-Ql for qemu-devel@nongnu.org; Thu, 07 Jul 2011 12:51:20 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p67GpJFf022606 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 7 Jul 2011 12:51:19 -0400 From: Alon Levy Date: Thu, 7 Jul 2011 18:50:52 +0200 Message-Id: <1310057455-18570-12-git-send-email-alevy@redhat.com> In-Reply-To: <1310057455-18570-1-git-send-email-alevy@redhat.com> References: <1310057455-18570-1-git-send-email-alevy@redhat.com> Subject: [Qemu-devel] [PATCH v2] qxl: only disallow specific io's in vga mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: yhalperi@redhat.com, kraxel@redhat.com Since the driver is still in operation even after moving to UNDEFINED, i.e. by destroying primary in any way. --- hw/qxl.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 395d994..e57ccf2 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1167,8 +1167,9 @@ static void ioport_write(void *opaque, uint32_t addr, uint32_t val) case QXL_IO_LOG: break; default: - if (d->mode == QXL_MODE_NATIVE || d->mode == QXL_MODE_COMPAT) + if (d->mode != QXL_MODE_VGA) { break; + } dprint(d, 1, "%s: unexpected port 0x%x (%s) in vga mode\n", __FUNCTION__, io_port, io_port_to_string(io_port)); /* be nice to buggy guest drivers */ -- 1.7.5.4