From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qf7iW-0005Ww-KF for qemu-devel@nongnu.org; Fri, 08 Jul 2011 05:51:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qf7iS-0004Of-KY for qemu-devel@nongnu.org; Fri, 08 Jul 2011 05:51:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53752) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qf7iR-0004OJ-QO for qemu-devel@nongnu.org; Fri, 08 Jul 2011 05:51:20 -0400 From: Gerd Hoffmann Date: Fri, 8 Jul 2011 11:50:51 +0200 Message-Id: <1310118673-26196-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1310118673-26196-1-git-send-email-kraxel@redhat.com> References: <1310118673-26196-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH 01/23] hw/usb-musb.c: Don't misuse usb_packet_complete() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Gerd Hoffmann From: Peter Maydell In musb_packet() handle final processing of non-asynchronous USB packets by directly calling musb_schedule_cb() rather than going through usb_packet_complete(). The latter will trigger an assertion because the packet doesn't belong to a device. Signed-off-by: Peter Maydell Signed-off-by: Gerd Hoffmann --- hw/usb-musb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb-musb.c b/hw/usb-musb.c index 21f35af..d15971f 100644 --- a/hw/usb-musb.c +++ b/hw/usb-musb.c @@ -616,7 +616,7 @@ static void musb_packet(MUSBState *s, MUSBEndPoint *ep, } ep->status[dir] = ret; - usb_packet_complete(s->port.dev, &ep->packey[dir].p); + musb_schedule_cb(s->port.dev, &ep->packey[dir].p); } static void musb_tx_packet_complete(USBPacket *packey, void *opaque) -- 1.7.1