qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, mdroth@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH v2 0/3]: Fix build issue with error.h
Date: Wed, 13 Jul 2011 11:23:31 -0300	[thread overview]
Message-ID: <1310567013-11058-1-git-send-email-lcapitulino@redhat.com> (raw)

A .c file including error.h and not including qemu-common.h will break the
build, because error.h uses a macro defined in qemu-common.h.

The simple and obvious fix would be to change error.h to include
qemu-common.h. But this is overkill, so this series does some splitting in
qemu-common.h and changes error.h to include only what it really needs.

Please, refer to the patches for more details.

v3
 o Drop license text from compiler.h

v2
 o Move compiler related macros from qemu-common.h to compiler.h

 compiler.h    |   31 +++++++++++++++++++++++++++++++
 error.h       |    1 +
 qemu-common.h |   25 +------------------------
 3 files changed, 33 insertions(+), 24 deletions(-)

             reply	other threads:[~2011-07-13 14:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-13 14:23 Luiz Capitulino [this message]
2011-07-13 14:23 ` [Qemu-devel] [PATCH 1/2] Introduce compiler.h header file Luiz Capitulino
2011-07-13 14:37   ` malc
2011-07-13 16:20     ` Luiz Capitulino
2011-07-13 16:47       ` malc
2011-07-13 15:04   ` Peter Maydell
2011-07-13 16:27     ` Luiz Capitulino
2011-07-13 20:39       ` Stefan Weil
2011-07-14 12:57         ` Luiz Capitulino
2011-07-14 14:15           ` malc
2011-07-14 14:26             ` Luiz Capitulino
2011-07-14 14:35               ` malc
2011-07-14 10:58       ` Peter Maydell
2011-07-13 14:23 ` [Qemu-devel] [PATCH 2/2] Error: Fix build when qemu-common.h is not included Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310567013-11058-1-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).