qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, mdroth@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH 2/2] Error: Fix build when qemu-common.h is not included
Date: Wed, 13 Jul 2011 11:23:33 -0300	[thread overview]
Message-ID: <1310567013-11058-3-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1310567013-11058-1-git-send-email-lcapitulino@redhat.com>

From: Luiz Capitulino <lcapitulino@gmail.com>

Commit e4ea5e2d0e0e4c5188ab45b66f3195062ae059dc added the use of
the macro GCC_FMT_ATTR to error.h, however compiler.h is not
included by error.h

This will cause a build error when files including error.h
don't include qemu-common.h (or compiler.h). Not an issue today
because the only file including it is json-parser.h and it does
include qemu-common.h, but let's get it fixed.

Signed-off-by: Luiz Capitulino <lcapitulino@gmail.com>
---
 error.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/error.h b/error.h
index 0f92a6f..6361f40 100644
--- a/error.h
+++ b/error.h
@@ -12,6 +12,7 @@
 #ifndef ERROR_H
 #define ERROR_H
 
+#include "compiler.h"
 #include <stdbool.h>
 
 /**
-- 
1.7.6.134.gcf13f

  parent reply	other threads:[~2011-07-13 14:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-13 14:23 [Qemu-devel] [PATCH v2 0/3]: Fix build issue with error.h Luiz Capitulino
2011-07-13 14:23 ` [Qemu-devel] [PATCH 1/2] Introduce compiler.h header file Luiz Capitulino
2011-07-13 14:37   ` malc
2011-07-13 16:20     ` Luiz Capitulino
2011-07-13 16:47       ` malc
2011-07-13 15:04   ` Peter Maydell
2011-07-13 16:27     ` Luiz Capitulino
2011-07-13 20:39       ` Stefan Weil
2011-07-14 12:57         ` Luiz Capitulino
2011-07-14 14:15           ` malc
2011-07-14 14:26             ` Luiz Capitulino
2011-07-14 14:35               ` malc
2011-07-14 10:58       ` Peter Maydell
2011-07-13 14:23 ` Luiz Capitulino [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-07-14 21:28 [Qemu-devel] [PATCH v4 0/3]: Fix build issue with error.h saga Luiz Capitulino
2011-07-14 21:28 ` [Qemu-devel] [PATCH 2/2] Error: Fix build when qemu-common.h is not included Luiz Capitulino
2011-07-12 19:00 [Qemu-devel] [PATCH v2 0/2]: Fix build issue with error.h Luiz Capitulino
2011-07-12 19:00 ` [Qemu-devel] [PATCH 2/2] Error: Fix build when qemu-common.h is not included Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310567013-11058-3-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).