qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Riku Voipio" <riku.voipio@iki.fi>,
	"Juha Riihimäki" <juha.riihimaki@nokia.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	patches@linaro.org
Subject: [Qemu-devel] [PATCH 04/12] hw/nand: Support multiple reads following READ STATUS
Date: Fri, 15 Jul 2011 15:58:18 +0100	[thread overview]
Message-ID: <1310741906-1606-5-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1310741906-1606-1-git-send-email-peter.maydell@linaro.org>

From: Juha Riihimäki <juha.riihimaki@nokia.com>

After receiving READ STATUS command all subsequent IO reads should return
the status register value until another command is issued.

Signed-off-by: Juha Riihimäki <juha.riihimaki@nokia.com>
[Riku Voipio: Fixes and restructuring patchset]
Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
[Peter Maydell: More fixes and cleanups for upstream submission]
Signed-off-by:  Peter Maydell <peter.maydell@linaro.org>
---
 hw/nand.c |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/hw/nand.c b/hw/nand.c
index 2e98f25..e6c551d 100644
--- a/hw/nand.c
+++ b/hw/nand.c
@@ -496,9 +496,14 @@ uint32_t nand_getio(NANDFlashState *s)
     for (offset = s->buswidth; offset--;) {
         x |= s->ioaddr[offset] << (offset << 3);
     }
-    s->addr   += s->buswidth;
-    s->ioaddr += s->buswidth;
-    s->iolen  -= s->buswidth;
+    /* after receiving READ STATUS command all subsequent reads will
+     * return the status register value until another command is issued
+     */
+    if (s->cmd != NAND_CMD_READSTATUS) {
+        s->addr   += s->buswidth;
+        s->ioaddr += s->buswidth;
+        s->iolen  -= s->buswidth;
+    }
     return x;
 }
 
-- 
1.7.1

  parent reply	other threads:[~2011-07-15 14:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-15 14:58 [Qemu-devel] [PATCH 00/12] bugfix and qdevify NAND and ONENAND devices Peter Maydell
2011-07-15 14:58 ` [Qemu-devel] [PATCH 01/12] hw/nand: Pass block device state to init function Peter Maydell
2011-07-15 14:58 ` [Qemu-devel] [PATCH 02/12] hw/nand: Support large NAND devices Peter Maydell
2011-07-15 14:58 ` [Qemu-devel] [PATCH 03/12] hw/nand: Support devices wider than 8 bits Peter Maydell
2011-07-15 14:58 ` Peter Maydell [this message]
2011-07-15 14:58 ` [Qemu-devel] [PATCH 05/12] hw/nand: Writing to NAND can only clear bits Peter Maydell
2011-07-15 14:58 ` [Qemu-devel] [PATCH 06/12] hw/nand: qdevify Peter Maydell
2011-07-15 14:58 ` [Qemu-devel] [PATCH 07/12] onenand: Pass BlockDriverState to init function Peter Maydell
2011-07-15 14:58 ` [Qemu-devel] [PATCH 08/12] onenand: Handle various ID fields separately Peter Maydell
2011-07-15 14:58 ` [Qemu-devel] [PATCH 09/12] onenand: Ignore zero writes to boot command space Peter Maydell
2011-07-15 14:58 ` [Qemu-devel] [PATCH 10/12] hw/onenand: program actions can only clear bits Peter Maydell
2011-07-15 14:58 ` [Qemu-devel] [PATCH 11/12] hw/sysbus: Add sysbus_mmio_unmap() for unmapping a region Peter Maydell
2011-07-15 14:58 ` [Qemu-devel] [PATCH 12/12] hw/onenand: qdevify Peter Maydell
2011-07-28 13:51 ` [Qemu-devel] [PATCH 00/12] bugfix and qdevify NAND and ONENAND devices Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310741906-1606-5-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=armbru@redhat.com \
    --cc=juha.riihimaki@nokia.com \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).