From: Stefan Weil <weil@mail.berlios.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>,
QEMU Developers <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>
Subject: [Qemu-devel] [PATCH 1/3] Fix conversions from pointer to tcg_target_long
Date: Fri, 15 Jul 2011 21:38:12 +0200 [thread overview]
Message-ID: <1310758694-6360-2-git-send-email-weil@mail.berlios.de> (raw)
In-Reply-To: <1310758694-6360-1-git-send-email-weil@mail.berlios.de>
tcg_gen_exit_tb takes a parameter of type tcg_target_long,
so the type casts of pointer to long should be replaced by
type casts of pointer to tcg_target_long.
These changes are needed for build environments where
sizeof(long) != sizeof(void *), especially for w64.
See 4b4a72e55660abf7efe85aca78762dcfea5519ad which fixed the
same issue for the other targets.
Cc: Alexander Graf <agraf@suse.de>
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
target-s390x/translate.c | 2 +-
target-unicore32/translate.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-s390x/translate.c b/target-s390x/translate.c
index 77fb448..6a22fde 100644
--- a/target-s390x/translate.c
+++ b/target-s390x/translate.c
@@ -830,7 +830,7 @@ static inline void gen_goto_tb(DisasContext *s, int tb_num, target_ulong pc)
/* jump to same page: we can use a direct jump */
tcg_gen_goto_tb(tb_num);
tcg_gen_movi_i64(psw_addr, pc);
- tcg_gen_exit_tb((long)tb + tb_num);
+ tcg_gen_exit_tb((tcg_target_long)tb + tb_num);
} else {
/* jump to another page: currently not optimized */
tcg_gen_movi_i64(psw_addr, pc);
diff --git a/target-unicore32/translate.c b/target-unicore32/translate.c
index a15e42d..4ecb0f1 100644
--- a/target-unicore32/translate.c
+++ b/target-unicore32/translate.c
@@ -1056,7 +1056,7 @@ static inline void gen_goto_tb(DisasContext *s, int n, uint32_t dest)
if ((tb->pc & TARGET_PAGE_MASK) == (dest & TARGET_PAGE_MASK)) {
tcg_gen_goto_tb(n);
gen_set_pc_im(dest);
- tcg_gen_exit_tb((long)tb + n);
+ tcg_gen_exit_tb((tcg_target_long)tb + n);
} else {
gen_set_pc_im(dest);
tcg_gen_exit_tb(0);
--
1.7.2.5
next prev parent reply other threads:[~2011-07-15 19:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-15 19:38 [Qemu-devel] New patches for w32, w64 Stefan Weil
2011-07-15 19:38 ` Stefan Weil [this message]
2011-07-18 3:19 ` [Qemu-devel] [PATCH 1/3] Fix conversions from pointer to tcg_target_long Guan Xuetao
2011-07-18 7:39 ` Alexander Graf
2011-07-15 19:38 ` [Qemu-devel] [PATCH 2/3] w64: Add definition of FMT_pid Stefan Weil
2011-07-15 20:39 ` Andreas Färber
2011-07-15 19:38 ` [Qemu-devel] [PATCH 3/3] w32: Fix format string regression Stefan Weil
2011-07-15 20:42 ` Andreas Färber
2011-07-17 9:03 ` Blue Swirl
2011-07-17 18:34 ` Stefan Weil
2011-07-17 21:31 ` Blue Swirl
2011-08-13 9:38 ` [Qemu-devel] New patches for w32, w64 Stefan Weil
2011-08-13 10:49 ` Blue Swirl
2011-08-21 16:40 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310758694-6360-2-git-send-email-weil@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=agraf@suse.de \
--cc=blauwirbel@gmail.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).