From: Stefan Weil <weil@mail.berlios.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH 3/3] w32: Fix format string regression
Date: Fri, 15 Jul 2011 21:38:14 +0200 [thread overview]
Message-ID: <1310758694-6360-4-git-send-email-weil@mail.berlios.de> (raw)
In-Reply-To: <1310758694-6360-1-git-send-email-weil@mail.berlios.de>
Commit 953ffe0f935f40c0d6061d69e76e0339393b54f8
introduced FMT_pid which is wrong for w32 and w64 getpid():
those getpid() implementations always return an int value.
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
os-win32.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/os-win32.c b/os-win32.c
index b6652af..e153058 100644
--- a/os-win32.c
+++ b/os-win32.c
@@ -258,7 +258,7 @@ int qemu_create_pidfile(const char *filename)
if (file == INVALID_HANDLE_VALUE) {
return -1;
}
- len = snprintf(buffer, sizeof(buffer), FMT_pid "\n", getpid());
+ len = snprintf(buffer, sizeof(buffer), "%d\n", getpid());
ret = WriteFileEx(file, (LPCVOID)buffer, (DWORD)len,
&overlap, NULL);
if (ret == 0) {
--
1.7.2.5
next prev parent reply other threads:[~2011-07-15 19:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-15 19:38 [Qemu-devel] New patches for w32, w64 Stefan Weil
2011-07-15 19:38 ` [Qemu-devel] [PATCH 1/3] Fix conversions from pointer to tcg_target_long Stefan Weil
2011-07-18 3:19 ` Guan Xuetao
2011-07-18 7:39 ` Alexander Graf
2011-07-15 19:38 ` [Qemu-devel] [PATCH 2/3] w64: Add definition of FMT_pid Stefan Weil
2011-07-15 20:39 ` Andreas Färber
2011-07-15 19:38 ` Stefan Weil [this message]
2011-07-15 20:42 ` [Qemu-devel] [PATCH 3/3] w32: Fix format string regression Andreas Färber
2011-07-17 9:03 ` Blue Swirl
2011-07-17 18:34 ` Stefan Weil
2011-07-17 21:31 ` Blue Swirl
2011-08-13 9:38 ` [Qemu-devel] New patches for w32, w64 Stefan Weil
2011-08-13 10:49 ` Blue Swirl
2011-08-21 16:40 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310758694-6360-4-git-send-email-weil@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).