From: Stefan Weil <weil@mail.berlios.de>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] Fix duplicate device reset
Date: Mon, 18 Jul 2011 22:22:26 +0200 [thread overview]
Message-ID: <1311020546-9769-1-git-send-email-weil@mail.berlios.de> (raw)
qbus_reset_all_fn was registered twice, so a lot of device reset
functions were also called twice when QEMU started.
It is sufficient to call sysbus_get_default() which will
register qbus_reset_all_fn.
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
vl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/vl.c b/vl.c
index fcd7395..fb2f6db 100644
--- a/vl.c
+++ b/vl.c
@@ -3301,7 +3301,7 @@ int main(int argc, char **argv, char **envp)
/* TODO: once all bus devices are qdevified, this should be done
* when bus is created by qdev.c */
- qemu_register_reset(qbus_reset_all_fn, sysbus_get_default());
+ sysbus_get_default();
qemu_run_machine_init_done_notifiers();
qemu_system_reset(VMRESET_SILENT);
--
1.7.2.5
next reply other threads:[~2011-07-18 20:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 20:22 Stefan Weil [this message]
2011-07-19 2:39 ` [Qemu-devel] [PATCH] Fix duplicate device reset Isaku Yamahata
2011-07-19 5:56 ` Stefan Weil
2011-07-19 7:22 ` Isaku Yamahata
2011-08-01 11:00 ` Isaku Yamahata
2011-08-01 20:45 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311020546-9769-1-git-send-email-weil@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).