From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 12/21] VMDK: probe for monolithicFlat images
Date: Tue, 19 Jul 2011 12:15:15 +0200 [thread overview]
Message-ID: <1311070524-13533-13-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1311070524-13533-1-git-send-email-kwolf@redhat.com>
From: Fam Zheng <famcool@gmail.com>
Probe as the same behavior as VMware does.
Recognize image as monolithicFlat descriptor file when the file is text
and the first effective line (not '#' leaded comment or space line) is
either 'version=1' or 'version=2'. No space or upper case charactors
accepted.
Signed-off-by: Fam Zheng <famcool@gmail.com>
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/vmdk.c | 45 +++++++++++++++++++++++++++++++++++++++++++--
1 files changed, 43 insertions(+), 2 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 03a4619..f8a815c 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -103,10 +103,51 @@ static int vmdk_probe(const uint8_t *buf, int buf_size, const char *filename)
return 0;
magic = be32_to_cpu(*(uint32_t *)buf);
if (magic == VMDK3_MAGIC ||
- magic == VMDK4_MAGIC)
+ magic == VMDK4_MAGIC) {
return 100;
- else
+ } else {
+ const char *p = (const char *)buf;
+ const char *end = p + buf_size;
+ while (p < end) {
+ if (*p == '#') {
+ /* skip comment line */
+ while (p < end && *p != '\n') {
+ p++;
+ }
+ p++;
+ continue;
+ }
+ if (*p == ' ') {
+ while (p < end && *p == ' ') {
+ p++;
+ }
+ /* skip '\r' if windows line endings used. */
+ if (p < end && *p == '\r') {
+ p++;
+ }
+ /* only accept blank lines before 'version=' line */
+ if (p == end || *p != '\n') {
+ return 0;
+ }
+ p++;
+ continue;
+ }
+ if (end - p >= strlen("version=X\n")) {
+ if (strncmp("version=1\n", p, strlen("version=1\n")) == 0 ||
+ strncmp("version=2\n", p, strlen("version=2\n")) == 0) {
+ return 100;
+ }
+ }
+ if (end - p >= strlen("version=X\r\n")) {
+ if (strncmp("version=1\r\n", p, strlen("version=1\r\n")) == 0 ||
+ strncmp("version=2\r\n", p, strlen("version=2\r\n")) == 0) {
+ return 100;
+ }
+ }
+ return 0;
+ }
return 0;
+ }
}
#define CHECK_CID 1
--
1.7.6
next prev parent reply other threads:[~2011-07-19 10:12 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 10:15 [Qemu-devel] [PULL 00/21] Block patches Kevin Wolf
2011-07-19 10:15 ` [Qemu-devel] [PATCH 01/21] sheepdog: add full data preallocation support Kevin Wolf
2011-07-19 10:15 ` [Qemu-devel] [PATCH 02/21] qemu-io: Fix formatting Kevin Wolf
2011-07-19 10:15 ` [Qemu-devel] [PATCH 03/21] qemu-io: Fix if scoping bug Kevin Wolf
2011-07-19 10:15 ` [Qemu-devel] [PATCH 04/21] iov: Update parameter usage in iov_(to|from)_buf() Kevin Wolf
2011-07-19 10:15 ` [Qemu-devel] [PATCH 05/21] scsi: Add 'hba_private' to SCSIRequest Kevin Wolf
2011-07-19 12:43 ` Anthony Liguori
2011-07-19 13:06 ` Kevin Wolf
2011-07-19 13:24 ` Benjamin Herrenschmidt
2011-07-19 13:26 ` Hannes Reinecke
2011-07-19 13:41 ` Kevin Wolf
2011-07-19 13:20 ` Benjamin Herrenschmidt
2011-07-20 5:49 ` David Gibson
2011-07-19 10:15 ` [Qemu-devel] [PATCH 06/21] scsi-disk: Fixup debugging statement Kevin Wolf
2011-07-19 10:15 ` [Qemu-devel] [PATCH 07/21] scsi-disk: Mask out serial number EVPD Kevin Wolf
2011-07-19 10:15 ` [Qemu-devel] [PATCH 08/21] qemu-options.hx: Document missing -drive options Kevin Wolf
2011-07-19 10:15 ` [Qemu-devel] [PATCH 09/21] qemu-config: Document " Kevin Wolf
2011-07-19 10:15 ` [Qemu-devel] [PATCH 10/21] VMDK: introduce VmdkExtent Kevin Wolf
2011-07-19 10:15 ` [Qemu-devel] [PATCH 11/21] VMDK: bugfix, align offset to cluster in get_whole_cluster Kevin Wolf
2011-07-19 10:15 ` Kevin Wolf [this message]
2011-07-19 10:15 ` [Qemu-devel] [PATCH 13/21] VMDK: separate vmdk_open by format version Kevin Wolf
2011-07-19 10:15 ` [Qemu-devel] [PATCH 14/21] VMDK: add field BDRVVmdkState.desc_offset Kevin Wolf
2011-07-19 10:15 ` [Qemu-devel] [PATCH 15/21] VMDK: flush multiple extents Kevin Wolf
2011-07-19 10:15 ` [Qemu-devel] [PATCH 16/21] VMDK: move 'static' cid_update flag to bs field Kevin Wolf
2011-07-19 10:15 ` [Qemu-devel] [PATCH 17/21] VMDK: change get_cluster_offset return type Kevin Wolf
2011-07-19 10:15 ` [Qemu-devel] [PATCH 18/21] VMDK: open/read/write for monolithicFlat image Kevin Wolf
2011-07-19 10:15 ` [Qemu-devel] [PATCH 19/21] VMDK: create different subformats Kevin Wolf
2011-07-19 10:15 ` [Qemu-devel] [PATCH 20/21] VMDK: fix coding style Kevin Wolf
2011-07-19 10:15 ` [Qemu-devel] [PATCH 21/21] block: add bdrv_get_allocated_file_size() operation Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311070524-13533-13-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).