From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:58631)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1QjADz-0007Nr-Gi
	for qemu-devel@nongnu.org; Tue, 19 Jul 2011 09:20:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1QjADx-0000Dy-87
	for qemu-devel@nongnu.org; Tue, 19 Jul 2011 09:20:34 -0400
Received: from gate.crashing.org ([63.228.1.57]:36927)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1QjADw-0000Dt-LK
	for qemu-devel@nongnu.org; Tue, 19 Jul 2011 09:20:33 -0400
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
In-Reply-To: <4E257BE6.7080108@codemonkey.ws>
References: <1311070524-13533-1-git-send-email-kwolf@redhat.com>
	<1311070524-13533-6-git-send-email-kwolf@redhat.com>
	<4E257BE6.7080108@codemonkey.ws>
Content-Type: text/plain; charset="UTF-8"
Date: Tue, 19 Jul 2011 23:20:22 +1000
Message-ID: <1311081622.25044.423.camel@pasglop>
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 05/21] scsi: Add 'hba_private' to
 SCSIRequest
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>

On Tue, 2011-07-19 at 07:43 -0500, Anthony Liguori wrote:
>=20
> This breaks the build:
>=20
> make[1]: Nothing to be done for `all'.
>    CC    ppc64-softmmu/spapr_vscsi.o
> /home/anthony/git/qemu/hw/spapr_vscsi.c: In function=20
> =E2=80=98vscsi_command_complete=E2=80=99:
> /home/anthony/git/qemu/hw/spapr_vscsi.c:535:34: error: =E2=80=98s=E2=80=
=99 undeclared=20
> (first use in this function)
> /home/anthony/git/qemu/hw/spapr_vscsi.c:535:34: note: each undeclared=20
> identifier is reported only once for each function it appears in
>=20
> This file is only built when libfdt is installed which is probably
> why=20
> you didn't catch it.
>=20
> Ben/David, is there a way we can still build most of this stuff
> without=20
> libfdt?  libfdt is still not commonly packaged by some distros.

That would be hard ... the DT stuff is pretty deeply involved. Might be
easier to try to fix the distro :-)

Which ones ?

Cheers,
Ben.