qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Richard W.M. Jones" <rjones@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: [Qemu-devel] [PATCH] Remove debugging messages.
Date: Tue, 19 Jul 2011 20:23:38 +0100	[thread overview]
Message-ID: <1311103418-29380-2-git-send-email-rjones@redhat.com> (raw)
In-Reply-To: <1311103418-29380-1-git-send-email-rjones@redhat.com>

From: "Richard W.M. Jones" <rjones@redhat.com>

When using qemu -machine accel=kvm:tcg, if KVM is not available you
get a load of debugging output:

  Could not access KVM kernel module: No such file or directory
  failed to initialize KVM: No such file or directory
  Back to tcg accelerator.

Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
---
 kvm-all.c |    1 -
 vl.c      |   14 --------------
 2 files changed, 0 insertions(+), 15 deletions(-)

diff --git a/kvm-all.c b/kvm-all.c
index cbc2532..35d698b 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -713,7 +713,6 @@ int kvm_init(void)
     s->vmfd = -1;
     s->fd = qemu_open("/dev/kvm", O_RDWR);
     if (s->fd == -1) {
-        fprintf(stderr, "Could not access KVM kernel module: %m\n");
         ret = -errno;
         goto err;
     }
diff --git a/vl.c b/vl.c
index fcd7395..83a08b6 100644
--- a/vl.c
+++ b/vl.c
@@ -1922,7 +1922,6 @@ static int configure_accelerator(void)
     char buf[10];
     int i, ret;
     bool accel_initalised = 0;
-    bool init_failed = 0;
 
     QemuOptsList *list = qemu_find_opts("machine");
     if (!QTAILQ_EMPTY(&list->head)) {
@@ -1944,15 +1943,6 @@ static int configure_accelerator(void)
                 *(accel_list[i].allowed) = 1;
                 ret = accel_list[i].init();
                 if (ret < 0) {
-                    init_failed = 1;
-                    if (!accel_list[i].available()) {
-                        printf("%s not supported for this target\n",
-                               accel_list[i].name);
-                    } else {
-                        fprintf(stderr, "failed to initialize %s: %s\n",
-                                accel_list[i].name,
-                                strerror(-ret));
-                    }
                     *(accel_list[i].allowed) = 0;
                 } else {
                     accel_initalised = 1;
@@ -1970,10 +1960,6 @@ static int configure_accelerator(void)
         exit(1);
     }
 
-    if (init_failed) {
-        fprintf(stderr, "Back to %s accelerator.\n", accel_list[i].name);
-    }
-
     return !accel_initalised;
 }
 
-- 
1.7.5.2

  reply	other threads:[~2011-07-19 19:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-19 19:23 [Qemu-devel] [PATCH 1/1] Remove debugging messages Richard W.M. Jones
2011-07-19 19:23 ` Richard W.M. Jones [this message]
2011-07-19 19:47   ` [Qemu-devel] [PATCH] " Jan Kiszka
2011-07-19 19:49   ` Michael Tokarev
2011-07-19 20:50     ` Richard W.M. Jones
2011-07-19 20:04   ` Anthony Liguori
2011-07-19 20:59     ` Richard W.M. Jones
2011-07-19 21:56       ` Anthony Liguori
2011-07-20  8:50         ` Richard W.M. Jones
2011-07-20 12:51           ` Anthony Liguori
2011-07-20 17:38             ` Richard W.M. Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1311103418-29380-2-git-send-email-rjones@redhat.com \
    --to=rjones@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).