From: Frediano Ziglio <freddy77@gmail.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Frediano Ziglio <freddy77@gmail.com>
Subject: [Qemu-devel] [RFC PATCH 5/5] qcow: small optimization initializing QCowAIOCB
Date: Wed, 20 Jul 2011 15:56:29 +0200 [thread overview]
Message-ID: <1311170189-29734-6-git-send-email-freddy77@gmail.com> (raw)
In-Reply-To: <1311170189-29734-1-git-send-email-freddy77@gmail.com>
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
---
block/qcow.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/qcow.c b/block/qcow.c
index 007fb57..8fd1ee5 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -499,7 +499,6 @@ static QCowAIOCB *qcow_aio_setup(BlockDriverState *bs,
int64_t sector_num, QEMUIOVector *qiov, int nb_sectors,
int is_write, QCowAIOCB *acb)
{
- memset(acb, 0, sizeof(*acb));
acb->bs = bs;
acb->sector_num = sector_num;
acb->qiov = qiov;
@@ -509,6 +508,7 @@ static QCowAIOCB *qcow_aio_setup(BlockDriverState *bs,
if (is_write)
qemu_iovec_to_buffer(qiov, acb->buf);
} else {
+ acb->orig_buf = NULL;
acb->buf = (uint8_t *)qiov->iov->iov_base;
}
acb->nb_sectors = nb_sectors;
--
1.7.1
next prev parent reply other threads:[~2011-07-20 14:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 13:56 [Qemu-devel] [RFC PATCH 0/5] qcow: coroutines cleanup Frediano Ziglio
2011-07-20 13:56 ` [Qemu-devel] [RFC PATCH 1/5] qcow: allocate QCowAIOCB structure using stack Frediano Ziglio
2011-07-20 13:56 ` [Qemu-devel] [RFC PATCH 2/5] qcow: QCowAIOCB field cleanup Frediano Ziglio
2011-07-22 7:01 ` Kevin Wolf
2011-07-20 13:56 ` [Qemu-devel] [RFC PATCH 3/5] qcow: move some blocks of code to avoid useless variable initialization Frediano Ziglio
2011-07-20 13:56 ` [Qemu-devel] [RFC PATCH 4/5] avoid dandling pointers Frediano Ziglio
2011-07-22 7:02 ` Kevin Wolf
2011-07-22 9:29 ` Frediano Ziglio
2011-07-20 13:56 ` Frediano Ziglio [this message]
2011-07-22 7:04 ` [Qemu-devel] [RFC PATCH 0/5] qcow: coroutines cleanup Kevin Wolf
2011-07-22 9:26 ` Frediano Ziglio
2011-07-22 10:10 ` Kevin Wolf
2011-07-22 11:00 ` Stefan Hajnoczi
2011-07-22 13:24 ` Frediano Ziglio
2011-07-22 13:39 ` Kevin Wolf
2011-07-22 13:48 ` Gerd Hoffmann
2011-07-22 20:09 ` Frediano Ziglio
2011-07-25 7:53 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311170189-29734-6-git-send-email-freddy77@gmail.com \
--to=freddy77@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).