From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjZZk-0003jq-CX for qemu-devel@nongnu.org; Wed, 20 Jul 2011 12:24:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QjZZe-0008PI-Vd for qemu-devel@nongnu.org; Wed, 20 Jul 2011 12:24:42 -0400 Received: from oxygen.pond.sub.org ([78.46.104.156]:55540) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjZZc-0008O2-Fu for qemu-devel@nongnu.org; Wed, 20 Jul 2011 12:24:37 -0400 From: Markus Armbruster Date: Wed, 20 Jul 2011 18:23:46 +0200 Message-Id: <1311179069-27882-13-git-send-email-armbru@redhat.com> In-Reply-To: <1311179069-27882-1-git-send-email-armbru@redhat.com> References: <1311179069-27882-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 12/55] ide: Fix ATA command READ to set ATAPI signature for CD-ROM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, quintela@redhat.com, dbaryshkov@gmail.com, stefano.stabellini@eu.citrix.com, lcapitulino@redhat.com, amit.shah@redhat.com Must set the ATAPI device signature, see ACS-2 7.36.6 Outputs for PACKET feature set devices. Signed-off-by: Markus Armbruster --- hw/ide/core.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index fa50692..f96ebf2 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -958,8 +958,10 @@ void ide_exec_cmd(IDEBus *bus, uint32_t val) lba48 = 1; case WIN_READ: case WIN_READ_ONCE: - if (!s->bs) + if (s->drive_kind == IDE_CD) { + ide_set_signature(s); goto abort_cmd; + } ide_cmd_lba48_transform(s, lba48); s->req_nb_sectors = 1; ide_sector_read(s); -- 1.7.2.3