From: Stefan Weil <weil@mail.berlios.de>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Blue Swirl <blauwirbel@gmail.com>
Subject: [Qemu-devel] [PATCH] tcg/mips: Fix regression caused by typo (copy + paste bug)
Date: Wed, 20 Jul 2011 20:56:36 +0200 [thread overview]
Message-ID: <1311188196-2867-2-git-send-email-weil@mail.berlios.de> (raw)
In-Reply-To: <1311188196-2867-1-git-send-email-weil@mail.berlios.de>
cppcheck reports an error:
qemu/tcg/mips/tcg-target.c:1487: error: Invalid number of character (()
The unpatched code won't compile on mips hosts starting with commit
cea5f9a28faa528b6b1b117c9ab2d8828f473fef.
Cc: Blue Swirl <blauwirbel@gmail.com>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
tcg/mips/tcg-target.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tcg/mips/tcg-target.c b/tcg/mips/tcg-target.c
index 12ff9d5..a33d21f 100644
--- a/tcg/mips/tcg-target.c
+++ b/tcg/mips/tcg-target.c
@@ -1484,7 +1484,7 @@ static void tcg_target_qemu_prologue(TCGContext *s)
}
/* Call generated code */
- tcg_out_opc_reg(s, OPC_JR, 0, tcg_target_call_iarg_regs[1]), 0);
+ tcg_out_opc_reg(s, OPC_JR, 0, tcg_target_call_iarg_regs[1], 0);
tcg_out_mov(s, TCG_TYPE_PTR, TCG_AREG0, tcg_target_call_iarg_regs[0]);
tb_ret_addr = s->code_ptr;
--
1.7.2.5
next prev parent reply other threads:[~2011-07-20 18:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 18:56 [Qemu-devel] [PATCH] sh4: Fix potential crash in debug code Stefan Weil
2011-07-20 18:56 ` Stefan Weil [this message]
2011-07-25 10:22 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2011-08-13 9:25 ` [Qemu-devel] " Stefan Weil
2011-08-27 19:27 ` Stefan Weil
2011-08-28 11:13 ` Andreas Färber
2011-08-29 11:39 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311188196-2867-2-git-send-email-weil@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).