[Qemu-devel] [PATCH] darwin-user: Remove two unused variables

[Qemu-devel] [PATCH] darwin-user: Remove two unused variables

[Stefan Weil]

cppcheck report:

darwin-user/signal.c:322: style: Unused variable: i
darwin-user/signal.c:322: style:
Variable 'err' is assigned a value that is never used

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 darwin-user/signal.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/darwin-user/signal.c b/darwin-user/signal.c
index e2adca3..c530227 100644
--- a/darwin-user/signal.c
+++ b/darwin-user/signal.c
@@ -319,7 +319,6 @@ static void setup_frame(int sig, struct emulated_sigaction *ka,
 			void *set, CPUState *env)
 {
 	void *frame;
-	int i, err = 0;
 
     fprintf(stderr, "setup_frame %d\n", sig);
 	frame = get_sigframe(ka, env, sizeof(*frame));
-- 
1.7.2.5

Re: [Qemu-devel] [PATCH] darwin-user: Remove two unused variables

[Andreas Färber]

Hi Stefan W.,

Am 20.07.2011 um 21:40 schrieb Stefan Weil:

> cppcheck report:
>
> darwin-user/signal.c:322: style: Unused variable: i
> darwin-user/signal.c:322: style:
> Variable 'err' is assigned a value that is never used

Does this really bug you? I'm a bit skeptical towards trying to fix  
warnings in code that doesn't compile either way... (or does it by now?)

Andreas

>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> darwin-user/signal.c |    1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/darwin-user/signal.c b/darwin-user/signal.c
> index e2adca3..c530227 100644
> --- a/darwin-user/signal.c
> +++ b/darwin-user/signal.c
> @@ -319,7 +319,6 @@ static void setup_frame(int sig, struct  
> emulated_sigaction *ka,
> 			void *set, CPUState *env)
> {
> 	void *frame;
> -	int i, err = 0;
>
>     fprintf(stderr, "setup_frame %d\n", sig);
> 	frame = get_sigframe(ka, env, sizeof(*frame));
> -- 
> 1.7.2.5
>
>

Re: [Qemu-devel] [PATCH] darwin-user: Remove two unused variables

[Stefan Weil]

Am 22.07.2011 22:48, schrieb Andreas Färber:
> Hi Stefan W.,
>
> Am 20.07.2011 um 21:40 schrieb Stefan Weil:
>
>> cppcheck report:
>>
>> darwin-user/signal.c:322: style: Unused variable: i
>> darwin-user/signal.c:322: style:
>> Variable 'err' is assigned a value that is never used
>
> Does this really bug you? I'm a bit skeptical towards trying to fix 
> warnings in code that doesn't compile either way... (or does it by now?)
>
> Andreas

Hi Andreas,

the warnings were the result of a static code inspection with
a program called cppcheck. I don't compile darwin code,
so I did not notice that the code does not compile.

Is there a good reason to keep those two unused variables?
Fixing the issue helps with static code analysis because
unnecessary manual code checks can be avoided.

Cheers,
Stefan

Re: [Qemu-devel] [PATCH] darwin-user: Remove two unused variables

[Blue Swirl]

Thanks, applied.

On Fri, Jul 22, 2011 at 9:43 PM, Stefan Weil <weil@mail.berlios.de> wrote:
> Am 22.07.2011 22:48, schrieb Andreas Färber:
>>
>> Hi Stefan W.,
>>
>> Am 20.07.2011 um 21:40 schrieb Stefan Weil:
>>
>>> cppcheck report:
>>>
>>> darwin-user/signal.c:322: style: Unused variable: i
>>> darwin-user/signal.c:322: style:
>>> Variable 'err' is assigned a value that is never used
>>
>> Does this really bug you? I'm a bit skeptical towards trying to fix
>> warnings in code that doesn't compile either way... (or does it by now?)
>>
>> Andreas
>
> Hi Andreas,
>
> the warnings were the result of a static code inspection with
> a program called cppcheck. I don't compile darwin code,
> so I did not notice that the code does not compile.
>
> Is there a good reason to keep those two unused variables?
> Fixing the issue helps with static code analysis because
> unnecessary manual code checks can be avoided.
>
> Cheers,
> Stefan
>
>
>