From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkZmj-0007mu-1y for qemu-devel@nongnu.org; Sat, 23 Jul 2011 06:50:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QkZmh-0005s9-Ov for qemu-devel@nongnu.org; Sat, 23 Jul 2011 06:50:17 -0400 Received: from cantor2.suse.de ([195.135.220.15]:54459 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkZmh-0005rj-I4 for qemu-devel@nongnu.org; Sat, 23 Jul 2011 06:50:15 -0400 From: Alexander Graf Date: Sat, 23 Jul 2011 12:49:50 +0200 Message-Id: <1311418212-13356-7-git-send-email-agraf@suse.de> In-Reply-To: <1311418212-13356-1-git-send-email-agraf@suse.de> References: <1311418212-13356-1-git-send-email-agraf@suse.de> Subject: [Qemu-devel] [PATCH 06/28] PPC: MPIC: Remove read functionality for WO registers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU-devel Developers Cc: Scott Wood , Elie Richa The IPI dispatch registers are write only according to every MPIC spec I have found. So instead of pretending you could read back something from them, better not handle them at all. Reported-by: Elie Richa Signed-off-by: Alexander Graf --- hw/openpic.c | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/hw/openpic.c b/hw/openpic.c index 1f7753d..3f50421 100644 --- a/hw/openpic.c +++ b/hw/openpic.c @@ -952,13 +952,6 @@ static uint32_t openpic_cpu_read_internal(void *opaque, target_phys_addr_t addr, case 0xB0: /* PEOI */ retval = 0; break; -#if MAX_IPI > 0 - case 0x40: /* IDE */ - case 0x50: - idx = (addr - 0x40) >> 4; - retval = read_IRQreg(opp, opp->irq_ipi0 + idx, IRQ_IDE); - break; -#endif default: break; } -- 1.6.0.2