From: TeLeMan <geleman@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-trivial@nongnu.org, TeLeMan <geleman@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH] qemu-char: fix the commit "qemu-char: Print strerror message on failure"
Date: Mon, 25 Jul 2011 16:16:31 +0800 [thread overview]
Message-ID: <1311581791-923-1-git-send-email-geleman@gmail.com> (raw)
The commit 6e1db57b2ac9025c2443c665a0d9e78748637b26 missed patching qemu_chr_open_win_file().
Signed-off-by: TeLeMan <geleman@gmail.com>
---
qemu-char.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index dcf7065..ea7abfe 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -1782,7 +1782,7 @@ static int qemu_chr_open_win_pipe(QemuOpts *opts, CharDriverState **_chr)
return 0;
}
-static CharDriverState *qemu_chr_open_win_file(HANDLE fd_out)
+static int qemu_chr_open_win_file(HANDLE fd_out, CharDriverState **_chr)
{
CharDriverState *chr;
WinCharState *s;
@@ -1793,12 +1793,14 @@ static CharDriverState *qemu_chr_open_win_file(HANDLE fd_out)
chr->opaque = s;
chr->chr_write = win_chr_write;
qemu_chr_generic_open(chr);
- return chr;
+
+ *_chr = chr;
+ return 0;
}
static int qemu_chr_open_win_con(QemuOpts *opts, CharDriverState **_chr)
{
- return qemu_chr_open_win_file(GetStdHandle(STD_OUTPUT_HANDLE), chr);
+ return qemu_chr_open_win_file(GetStdHandle(STD_OUTPUT_HANDLE), _chr);
}
static int qemu_chr_open_win_file_out(QemuOpts *opts, CharDriverState **_chr)
--
1.7.3.1.msysgit.0
next reply other threads:[~2011-07-25 8:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 8:16 TeLeMan [this message]
2011-07-25 8:28 ` [Qemu-devel] [PATCH] qemu-char: fix the commit "qemu-char: Print strerror message on failure" TeLeMan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311581791-923-1-git-send-email-geleman@gmail.com \
--to=geleman@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).