From: Alexandre Raymond <cerbere@gmail.com>
To: Qemu Developers <qemu-devel@nongnu.org>
Cc: qemu-trivial@nongnu.org, Alexandre Raymond <cerbere@gmail.com>
Subject: [Qemu-devel] [PATCH 1/2] Makefile: distclean should clean all possible targets
Date: Mon, 25 Jul 2011 23:56:01 -0400 [thread overview]
Message-ID: <1311652562-10794-2-git-send-email-cerbere@gmail.com> (raw)
In-Reply-To: <1311652562-10794-1-git-send-email-cerbere@gmail.com>
At the moment, "make distclean" relies on the TARGET_DIRS variable, set by
configure. The problem is that this variable does not always contain all
possible targets.
For example, the following will leave build data in the tree:
./configure && make && ./configure --target-list=i386-softmmu \
&& make distclean
as it will only remove the i386-softmmu build directory, although the
first build created additional directories.
Solution : pass the full list of targets from configure to make via
the DEFAULT_TARGET_LIST variable.
Signed-off-by: Alexandre Raymond <cerbere@gmail.com>
---
Makefile | 2 +-
configure | 1 +
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 723d41f..878402e 100644
--- a/Makefile
+++ b/Makefile
@@ -225,7 +225,7 @@ distclean: clean
rm -f qemu-doc.log qemu-doc.pdf qemu-doc.pg qemu-doc.toc qemu-doc.tp
rm -f qemu-doc.vr
rm -f qemu-tech.info qemu-tech.aux qemu-tech.cp qemu-tech.dvi qemu-tech.fn qemu-tech.info qemu-tech.ky qemu-tech.log qemu-tech.pdf qemu-tech.pg qemu-tech.toc qemu-tech.tp qemu-tech.vr
- for d in $(TARGET_DIRS) $(QEMULIBS); do \
+ for d in $(DEFAULT_TARGET_LIST) $(QEMULIBS); do \
rm -rf $$d || exit 1 ; \
done
diff --git a/configure b/configure
index 600da9b..83f980a 100755
--- a/configure
+++ b/configure
@@ -2810,6 +2810,7 @@ qemu_version=`head $source_path/VERSION`
echo "VERSION=$qemu_version" >>$config_host_mak
echo "PKGVERSION=$pkgversion" >>$config_host_mak
echo "SRC_PATH=$source_path" >> $config_host_mak
+echo "DEFAULT_TARGET_LIST=$default_target_list" >> $config_host_mak
echo "TARGET_DIRS=$target_list" >> $config_host_mak
if [ "$docs" = "yes" ] ; then
echo "BUILD_DOCS=yes" >> $config_host_mak
--
1.7.5
next prev parent reply other threads:[~2011-07-26 3:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-26 3:56 [Qemu-devel] [PATCH 0/2] Minor makefile fixes Alexandre Raymond
2011-07-26 3:56 ` Alexandre Raymond [this message]
2011-07-26 6:47 ` [Qemu-devel] [PATCH 1/2] Makefile: distclean should clean all possible targets Markus Armbruster
2011-07-26 13:51 ` Alexandre Raymond
2011-07-27 5:57 ` Markus Armbruster
2011-07-27 13:55 ` Alexandre Raymond
2011-07-27 14:42 ` [Qemu-devel] [Qemu-trivial] " Michael Roth
2011-07-29 11:20 ` Paolo Bonzini
2011-07-26 3:56 ` [Qemu-devel] [PATCH 2/2] Makefile: delete config.log in distclean Alexandre Raymond
2011-07-29 11:07 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311652562-10794-2-git-send-email-cerbere@gmail.com \
--to=cerbere@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).