qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH v2 16/23] ioport: register ranges by byte aligned addresses always
Date: Tue, 26 Jul 2011 14:26:15 +0300	[thread overview]
Message-ID: <1311679582-11211-17-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1311679582-11211-1-git-send-email-avi@redhat.com>

The I/O port space is byte addressable, even for word and long accesses.

An example is the VMware svga card, which has long ports on offsets 0,
1, and 2.

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
---
 ioport.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ioport.c b/ioport.c
index 0d2611d..a32483b 100644
--- a/ioport.c
+++ b/ioport.c
@@ -146,7 +146,7 @@ int register_ioport_read(pio_addr_t start, int length, int size,
         hw_error("register_ioport_read: invalid size");
         return -1;
     }
-    for(i = start; i < start + length; i += size) {
+    for(i = start; i < start + length; ++i) {
         ioport_read_table[bsize][i] = func;
         if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque)
             hw_error("register_ioport_read: invalid opaque for address 0x%x",
@@ -166,7 +166,7 @@ int register_ioport_write(pio_addr_t start, int length, int size,
         hw_error("register_ioport_write: invalid size");
         return -1;
     }
-    for(i = start; i < start + length; i += size) {
+    for(i = start; i < start + length; ++i) {
         ioport_write_table[bsize][i] = func;
         if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque)
             hw_error("register_ioport_write: invalid opaque for address 0x%x",
-- 
1.7.5.3

  parent reply	other threads:[~2011-07-26 11:26 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-26 11:25 [Qemu-devel] [PATCH v2 00/23] Memory API, batch 1 Avi Kivity
2011-07-26 11:26 ` [Qemu-devel] [PATCH v2 01/23] Add memory API documentation Avi Kivity
2011-07-26 11:26 ` [Qemu-devel] [PATCH v2 02/23] Hierarchical memory region API Avi Kivity
2011-07-26 11:26 ` [Qemu-devel] [PATCH v2 03/23] memory: implement dirty tracking Avi Kivity
2011-07-26 11:26 ` [Qemu-devel] [PATCH v2 04/23] memory: merge adjacent segments of a single memory region Avi Kivity
2011-07-26 11:36   ` Paolo Bonzini
2011-07-26 11:38     ` Avi Kivity
2011-07-26 11:51       ` Paolo Bonzini
2011-07-26 12:04         ` Avi Kivity
2011-07-26 15:41     ` Richard Henderson
2011-07-26 16:04       ` Avi Kivity
2011-07-26 11:26 ` [Qemu-devel] [PATCH v2 05/23] Internal interfaces for memory API Avi Kivity
2011-07-26 11:26 ` [Qemu-devel] [PATCH v2 06/23] memory: abstract address space operations Avi Kivity
2011-07-26 11:26 ` [Qemu-devel] [PATCH v2 07/23] memory: rename MemoryRegion::has_ram_addr to ::terminates Avi Kivity
2011-07-26 11:26 ` [Qemu-devel] [PATCH v2 08/23] memory: late initialization of ram_addr Avi Kivity
2011-07-26 11:26 ` [Qemu-devel] [PATCH v2 09/23] memory: I/O address space support Avi Kivity
2011-07-26 11:26 ` [Qemu-devel] [PATCH v2 10/23] memory: add backward compatibility for old portio registration Avi Kivity
2011-07-26 11:26 ` [Qemu-devel] [PATCH v2 11/23] memory: add backward compatibility for old mmio registration Avi Kivity
2011-07-26 11:26 ` [Qemu-devel] [PATCH v2 12/23] memory: add ioeventfd support Avi Kivity
2011-07-26 11:26 ` [Qemu-devel] [PATCH v2 13/23] memory: separate building the final memory map into two steps Avi Kivity
2011-07-26 11:26 ` [Qemu-devel] [PATCH v2 14/23] memory: transaction API Avi Kivity
2011-07-26 11:26 ` [Qemu-devel] [PATCH v2 15/23] exec.c: initialize memory map Avi Kivity
2011-07-26 11:26 ` Avi Kivity [this message]
2011-07-26 11:26 ` [Qemu-devel] [PATCH v2 17/23] pc: grab system_memory Avi Kivity
2011-07-26 11:26 ` [Qemu-devel] [PATCH v2 18/23] pc: convert pc_memory_init() to memory API Avi Kivity
2011-07-26 11:26 ` [Qemu-devel] [PATCH v2 19/23] pc: move global memory map out of pc_init1() and into its callers Avi Kivity
2011-07-26 11:26 ` [Qemu-devel] [PATCH v2 20/23] pci: pass address space to pci bus when created Avi Kivity
2011-07-26 11:26 ` [Qemu-devel] [PATCH v2 21/23] pci: add MemoryRegion based BAR management API Avi Kivity
2011-07-26 11:26 ` [Qemu-devel] [PATCH v2 22/23] sysbus: add MemoryRegion based memory " Avi Kivity
2011-07-26 11:26 ` [Qemu-devel] [PATCH v2 23/23] usb-ohci: convert to MemoryRegion Avi Kivity
2011-07-29 14:18 ` [Qemu-devel] [PATCH v2 00/23] Memory API, batch 1 Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1311679582-11211-17-git-send-email-avi@redhat.com \
    --to=avi@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).