From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 3/7] slirp: Fix unusual "comments" in unused code
Date: Wed, 27 Jul 2011 10:17:28 +0100 [thread overview]
Message-ID: <1311758252-10072-4-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1311758252-10072-1-git-send-email-stefanha@linux.vnet.ibm.com>
From: Stefan Weil <weil@mail.berlios.de>
cppcheck detected two rather strange comments which were not
correctly written as C comments.
They did not cause any harm because they were framed by
#ifdef notdef ... #endif, so they were never compiled.
Fix them nevertheless (we could also remove the unused code).
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
slirp/ip_input.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/slirp/ip_input.c b/slirp/ip_input.c
index 5e67631..c7b3eb4 100644
--- a/slirp/ip_input.c
+++ b/slirp/ip_input.c
@@ -511,7 +511,7 @@ typedef uint32_t n_time;
*/
break;
}
- off--; / * 0 origin * /
+ off--; /* 0 origin */
if (off > optlen - sizeof(struct in_addr)) {
/*
* End of source route. Should be for us.
@@ -554,7 +554,7 @@ typedef uint32_t n_time;
/*
* If no space remains, ignore.
*/
- off--; * 0 origin *
+ off--; /* 0 origin */
if (off > optlen - sizeof(struct in_addr))
break;
bcopy((caddr_t)(&ip->ip_dst), (caddr_t)&ipaddr.sin_addr,
--
1.7.5.4
next prev parent reply other threads:[~2011-07-27 9:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 9:17 [Qemu-devel] [PULL 0/7] Trivial patches for June 25 to July 27 2011 Stefan Hajnoczi
2011-07-27 9:17 ` [Qemu-devel] [PATCH 1/7] vhost build fix for i386 Stefan Hajnoczi
2011-07-27 9:17 ` [Qemu-devel] [PATCH 2/7] Makefile: Minor cscope fixups Stefan Hajnoczi
2011-07-27 9:17 ` Stefan Hajnoczi [this message]
2011-07-27 9:17 ` [Qemu-devel] [PATCH 4/7] Makefile: fix out-of-tree builds Stefan Hajnoczi
2011-07-27 14:18 ` Alexandre Raymond
2011-07-27 14:57 ` Stefan Hajnoczi
2011-07-27 9:17 ` [Qemu-devel] [PATCH 5/7] qmp: fix efect -> effect typo in qmp-commands.hx Stefan Hajnoczi
2011-07-27 9:17 ` [Qemu-devel] [PATCH 6/7] Makefile: add missing deps on $(GENERATED_HEADERS) Stefan Hajnoczi
2011-07-27 9:17 ` [Qemu-devel] [PATCH 7/7] xen_mapcache: remove unused variable Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311758252-10072-4-git-send-email-stefanha@linux.vnet.ibm.com \
--to=stefanha@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).