From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qm0QN-0003uw-IV for qemu-devel@nongnu.org; Wed, 27 Jul 2011 05:29:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qm0QL-0001o3-4I for qemu-devel@nongnu.org; Wed, 27 Jul 2011 05:29:07 -0400 Received: from mail-gx0-f173.google.com ([209.85.161.173]:53885) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qm0QK-0001ny-UP for qemu-devel@nongnu.org; Wed, 27 Jul 2011 05:29:05 -0400 Received: by gxk26 with SMTP id 26so1077767gxk.4 for ; Wed, 27 Jul 2011 02:29:04 -0700 (PDT) From: Fam Zheng Date: Wed, 27 Jul 2011 17:27:46 +0800 Message-Id: <1311758866-30029-7-git-send-email-famcool@gmail.com> In-Reply-To: <1311758866-30029-1-git-send-email-famcool@gmail.com> References: <1311758866-30029-1-git-send-email-famcool@gmail.com> Subject: [Qemu-devel] [PATCH 6/6] VMDK: creating streamOptimized subformat List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, Fam Zheng , hch@lst.de, stefanha@gmail.com Creating streamOptimized subformat. Added subformat option 'streamOptimized', to create a image with compression enabled and each cluster with a GrainMarker. Signed-off-by: Fam Zheng --- block/vmdk.c | 18 ++++++++++++------ 1 files changed, 12 insertions(+), 6 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 4799aa5..52e518d 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1088,7 +1088,8 @@ static int vmdk_write(BlockDriverState *bs, int64_t sector_num, } -static int vmdk_create_extent(const char *filename, int64_t filesize, bool flat) +static int vmdk_create_extent(const char *filename, int64_t filesize, + bool flat, bool compress) { int ret, i; int fd = 0; @@ -1112,7 +1113,9 @@ static int vmdk_create_extent(const char *filename, int64_t filesize, bool flat) magic = cpu_to_be32(VMDK4_MAGIC); memset(&header, 0, sizeof(header)); header.version = 1; - header.flags = 3; /* ?? */ + header.flags = + 3 | (compress ? VMDK4_FLAG_COMPRESS | VMDK4_FLAG_MARKER : 0); + header.compressAlgorithm = compress ? VMDK4_COMPRESSION_DEFLATE : 0; header.capacity = filesize / 512; header.granularity = 128; header.num_gtes_per_gte = 512; @@ -1142,6 +1145,7 @@ static int vmdk_create_extent(const char *filename, int64_t filesize, bool flat) header.rgd_offset = cpu_to_le64(header.rgd_offset); header.gd_offset = cpu_to_le64(header.gd_offset); header.grain_offset = cpu_to_le64(header.grain_offset); + header.compressAlgorithm = cpu_to_le16(header.compressAlgorithm); header.check_bytes[0] = 0xa; header.check_bytes[1] = 0x20; @@ -1283,7 +1287,7 @@ static int vmdk_create(const char *filename, QEMUOptionParameter *options) const char *fmt = NULL; int flags = 0; int ret = 0; - bool flat, split; + bool flat, split, compress; char ext_desc_lines[BUF_SIZE] = ""; char path[PATH_MAX], prefix[PATH_MAX], postfix[PATH_MAX]; const int64_t split_size = 0x80000000; /* VMDK has constant split size */ @@ -1332,7 +1336,8 @@ static int vmdk_create(const char *filename, QEMUOptionParameter *options) } else if (strcmp(fmt, "monolithicFlat") && strcmp(fmt, "monolithicSparse") && strcmp(fmt, "twoGbMaxExtentSparse") && - strcmp(fmt, "twoGbMaxExtentFlat")) { + strcmp(fmt, "twoGbMaxExtentFlat") && + strcmp(fmt, "streamOptimized")) { fprintf(stderr, "VMDK: Unknown subformat: %s\n", fmt); return -EINVAL; } @@ -1340,6 +1345,7 @@ static int vmdk_create(const char *filename, QEMUOptionParameter *options) strcmp(fmt, "twoGbMaxExtentSparse")); flat = !(strcmp(fmt, "monolithicFlat") && strcmp(fmt, "twoGbMaxExtentFlat")); + compress = !strcmp(fmt, "streamOptimized"); if (flat) { desc_extent_line = "RW %lld FLAT \"%s\" 0\n"; } else { @@ -1394,7 +1400,7 @@ static int vmdk_create(const char *filename, QEMUOptionParameter *options) snprintf(ext_filename, sizeof(ext_filename), "%s%s", path, desc_filename); - if (vmdk_create_extent(ext_filename, size, flat)) { + if (vmdk_create_extent(ext_filename, size, flat, compress)) { return -EINVAL; } filesize -= size; @@ -1508,7 +1514,7 @@ static QEMUOptionParameter vmdk_create_options[] = { .type = OPT_STRING, .help = "VMDK flat extent format, can be one of " - "{monolithicSparse (default) | monolithicFlat | twoGbMaxExtentSparse | twoGbMaxExtentFlat} " + "{monolithicSparse (default) | monolithicFlat | twoGbMaxExtentSparse | twoGbMaxExtentFlat | streamOptimized} " }, { NULL } };