From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>, Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PATCH 7/7] target-arm: Don't print debug messages for various UNDEF cases
Date: Wed, 27 Jul 2011 14:26:19 +0100 [thread overview]
Message-ID: <1311773179-23139-8-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1311773179-23139-1-git-send-email-peter.maydell@linaro.org>
Remove some stray printfs for cases which don't generally happen
(some VFP UNDEF cases, reads and writes to unknown cp14 registers);
we should simply generate an UNDEF when the instruction is executed.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
target-arm/translate.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/target-arm/translate.c b/target-arm/translate.c
index fcb41d1..75c0ad4 100644
--- a/target-arm/translate.c
+++ b/target-arm/translate.c
@@ -3288,12 +3288,10 @@ static int disas_vfp_insn(CPUState * env, DisasContext *s, uint32_t insn)
gen_vfp_toul(dp, 32 - rm, 0);
break;
default: /* undefined */
- printf ("rn:%d\n", rn);
return 1;
}
break;
default: /* undefined */
- printf ("op:%d\n", op);
return 1;
}
@@ -6372,8 +6370,6 @@ static int disas_cp14_read(CPUState * env, DisasContext *s, uint32_t insn)
return 0;
}
}
- fprintf(stderr, "Unknown cp14 read op1:%d crn:%d crm:%d op2:%d\n",
- op1, crn, crm, op2);
return 1;
}
@@ -6405,8 +6401,6 @@ static int disas_cp14_write(CPUState * env, DisasContext *s, uint32_t insn)
return 0;
}
}
- fprintf(stderr, "Unknown cp14 write op1:%d crn:%d crm:%d op2:%d\n",
- op1, crn, crm, op2);
return 1;
}
--
1.7.1
next prev parent reply other threads:[~2011-07-27 13:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 13:26 [Qemu-devel] [PULL 0/7] ARM patch queue (for master) Peter Maydell
2011-07-27 13:26 ` [Qemu-devel] [PATCH 1/7] target-arm: make VMSAv7 remapping and AP dependent on V6K Peter Maydell
2011-07-27 13:26 ` [Qemu-devel] [PATCH 2/7] target-arm: support for ARM1176JZF-s cores Peter Maydell
2011-07-27 13:26 ` [Qemu-devel] [PATCH 3/7] target-arm: Mark 1136r1 as a v6K core Peter Maydell
2011-07-27 13:26 ` [Qemu-devel] [PATCH 4/7] target-arm: Support v6 barriers in linux-user mode Peter Maydell
2011-07-27 13:26 ` [Qemu-devel] [PATCH 5/7] target-arm: Handle UNDEF and UNPREDICTABLE cases for VLDM, VSTM Peter Maydell
2011-07-27 13:26 ` [Qemu-devel] [PATCH 6/7] target-arm: UNDEF on a VCVTT/VCVTB UNPREDICTABLE to avoid TCG assert Peter Maydell
2011-07-27 13:26 ` Peter Maydell [this message]
2011-08-08 9:54 ` [Qemu-devel] [PULL 0/7] ARM patch queue (for master) Peter Maydell
2011-08-09 17:30 ` Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311773179-23139-8-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).