From: Frediano Ziglio <freddy77@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Frediano Ziglio <freddy77@gmail.com>
Subject: [Qemu-devel] [PATCH 1/8] qcow2: removed unused fields
Date: Thu, 28 Jul 2011 09:40:34 +0200 [thread overview]
Message-ID: <1311838841-4853-2-git-send-email-freddy77@gmail.com> (raw)
In-Reply-To: <1311838841-4853-1-git-send-email-freddy77@gmail.com>
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
---
block/qcow2.c | 10 +++-------
1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index edc068e..5c454bb 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -381,11 +381,8 @@ typedef struct QCowAIOCB {
uint64_t bytes_done;
uint64_t cluster_offset;
uint8_t *cluster_data;
- bool is_write;
QEMUIOVector hd_qiov;
- QEMUBH *bh;
QCowL2Meta l2meta;
- QLIST_ENTRY(QCowAIOCB) next_depend;
} QCowAIOCB;
/*
@@ -517,13 +514,12 @@ static int qcow2_aio_read_cb(QCowAIOCB *acb)
static QCowAIOCB *qcow2_aio_setup(BlockDriverState *bs, int64_t sector_num,
QEMUIOVector *qiov, int nb_sectors,
BlockDriverCompletionFunc *cb,
- void *opaque, int is_write, QCowAIOCB *acb)
+ void *opaque, QCowAIOCB *acb)
{
memset(acb, 0, sizeof(*acb));
acb->common.bs = bs;
acb->sector_num = sector_num;
acb->qiov = qiov;
- acb->is_write = is_write;
qemu_iovec_init(&acb->hd_qiov, qiov->niov);
@@ -543,7 +539,7 @@ static int qcow2_co_readv(BlockDriverState *bs, int64_t sector_num,
QCowAIOCB acb;
int ret;
- qcow2_aio_setup(bs, sector_num, qiov, nb_sectors, NULL, NULL, 0, &acb);
+ qcow2_aio_setup(bs, sector_num, qiov, nb_sectors, NULL, NULL, &acb);
qemu_co_mutex_lock(&s->lock);
do {
@@ -658,7 +654,7 @@ static int qcow2_co_writev(BlockDriverState *bs,
QCowAIOCB acb;
int ret;
- qcow2_aio_setup(bs, sector_num, qiov, nb_sectors, NULL, NULL, 1, &acb);
+ qcow2_aio_setup(bs, sector_num, qiov, nb_sectors, NULL, NULL, &acb);
s->cluster_cache_offset = -1; /* disable compressed cache */
qemu_co_mutex_lock(&s->lock);
--
1.7.1
next prev parent reply other threads:[~2011-07-28 7:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 7:40 [Qemu-devel] [PATCH 0/8] qcow2 cleanup for coroutine-block branch Frediano Ziglio
2011-07-28 7:40 ` Frediano Ziglio [this message]
2011-07-28 7:40 ` [Qemu-devel] [PATCH 2/8] qcow2: removed cur_nr_sectors field in QCowAIOCB Frediano Ziglio
2011-07-28 7:40 ` [Qemu-devel] [PATCH 3/8] qcow2: remove l2meta from QCowAIOCB Frediano Ziglio
2011-07-28 7:40 ` [Qemu-devel] [PATCH 4/8] qcow2: remove cluster_offset " Frediano Ziglio
2011-07-28 7:40 ` [Qemu-devel] [PATCH 5/8] qcow2: remove common " Frediano Ziglio
2011-07-28 7:40 ` [Qemu-devel] [PATCH 6/8] qcow2: reindent and use while before the big jump Frediano Ziglio
2011-07-28 7:40 ` [Qemu-devel] [PATCH 7/8] qcow2: removed QCowAIOCB entirely Frediano Ziglio
2011-07-28 7:40 ` [Qemu-devel] [PATCH 8/8] qcow2: remove memory leak Frediano Ziglio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311838841-4853-2-git-send-email-freddy77@gmail.com \
--to=freddy77@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).