From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 0.15 4/4] Partially revert "savevm: fix corruption in vmstate_subsection_load()."
Date: Fri, 29 Jul 2011 17:33:05 +0200 [thread overview]
Message-ID: <1311953585-16021-5-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1311953585-16021-1-git-send-email-pbonzini@redhat.com>
This reverts the additional check in commit eb60260d (but not the
assertions).
The new format does not require the check, and with the old format
it traded one kind of bogus failure for a different kind of silent
failure.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
savevm.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/savevm.c b/savevm.c
index 197af4b..c849914 100644
--- a/savevm.c
+++ b/savevm.c
@@ -1687,10 +1687,6 @@ static int vmstate_subsection_load(QEMUFile *f, const VMStateDescription *vmsd,
{
const VMStateSubsection *sub = vmsd->subsections;
- if (!sub || !sub->needed) {
- return 0;
- }
-
while (qemu_peek_byte(f) == QEMU_VM_SUBSECTION) {
char idstr[256];
int ret;
--
1.7.6
next prev parent reply other threads:[~2011-07-29 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-29 15:33 [Qemu-devel] [PATCH v2 0.15 0/4] Fix subsection ambiguity in the migration format Paolo Bonzini
2011-07-29 15:33 ` [Qemu-devel] [PATCH v2 0.15 1/4] add support for machine models to specify their " Paolo Bonzini
2011-07-29 15:33 ` [Qemu-devel] [PATCH v2 0.15 2/4] add pc-0.14 machine Paolo Bonzini
2011-07-29 15:33 ` [Qemu-devel] [PATCH v2 0.15 3/4] savevm: define new unambiguous migration format Paolo Bonzini
2011-07-29 15:33 ` Paolo Bonzini [this message]
2011-08-02 23:06 ` [Qemu-devel] [PATCH v2 0.15 0/4] Fix subsection ambiguity in the " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311953585-16021-5-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).