From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qn1PY-0007m7-PA for qemu-devel@nongnu.org; Sat, 30 Jul 2011 00:44:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qn1PX-0002YJ-SP for qemu-devel@nongnu.org; Sat, 30 Jul 2011 00:44:28 -0400 Received: from mail-pz0-f43.google.com ([209.85.210.43]:57830) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qn1PX-0002Xw-MC for qemu-devel@nongnu.org; Sat, 30 Jul 2011 00:44:27 -0400 Received: by pzk1 with SMTP id 1so7878037pzk.30 for ; Fri, 29 Jul 2011 21:44:25 -0700 (PDT) From: Fam Zheng Date: Sat, 30 Jul 2011 12:43:47 +0800 Message-Id: <1312001027-1249-1-git-send-email-famcool@gmail.com> In-Reply-To: <1311758866-30029-2-git-send-email-famcool@gmail.com> References: <1311758866-30029-2-git-send-email-famcool@gmail.com> Subject: Re: [Qemu-devel] [PATCH 1/6] VMDK: enable twoGbMaxExtentFlat List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, Fam Zheng , hch@lst.de, stefanha@gmail.com Enable the createType 'twoGbMaxExtentFlat'. The supporting code is already in. Signed-off-by: Fam Zheng --- block/vmdk.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 37478d2..e22a893 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -551,7 +551,8 @@ static int vmdk_open_desc_file(BlockDriverState *bs, int flags) if (vmdk_parse_description(buf, "createType", ct, sizeof(ct))) { return -EINVAL; } - if (strcmp(ct, "monolithicFlat")) { + if (strcmp(ct, "monolithicFlat") && + strcmp(ct, "twoGbMaxExtentFlat")) { fprintf(stderr, "VMDK: Not supported image type \"%s\""".\n", ct); return -ENOTSUP; @@ -672,6 +673,7 @@ static int get_cluster_offset(BlockDriverState *bs, return 0; } + offset -= (extent->end_sector - extent->sectors) * SECTOR_SIZE; l1_index = (offset >> 9) / extent->l1_entry_sectors; if (l1_index >= extent->l1_size) { return -1;