qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH 34/39] pci: remove pci_register_bar_simple()
Date: Sun, 31 Jul 2011 20:57:57 +0300	[thread overview]
Message-ID: <1312135082-31985-35-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1312135082-31985-1-git-send-email-avi@redhat.com>

Superceded by pci_register_bar_region().
---
 hw/pci.c |   17 -----------------
 hw/pci.h |    3 ---
 2 files changed, 0 insertions(+), 20 deletions(-)

diff --git a/hw/pci.c b/hw/pci.c
index 980840f..6aca1af 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -903,7 +903,6 @@ void pci_register_bar(PCIDevice *pci_dev, int region_num,
     r->filtered_size = size;
     r->type = type;
     r->map_func = map_func;
-    r->ram_addr = IO_MEM_UNASSIGNED;
     r->memory = NULL;
 
     wmask = ~(size - 1);
@@ -923,13 +922,6 @@ void pci_register_bar(PCIDevice *pci_dev, int region_num,
     }
 }
 
-static void pci_simple_bar_mapfunc(PCIDevice *pci_dev, int region_num,
-                                   pcibus_t addr, pcibus_t size, int type)
-{
-    cpu_register_physical_memory(addr, size,
-                                 pci_dev->io_regions[region_num].ram_addr);
-}
-
 static void pci_simple_bar_mapfunc_region(PCIDevice *pci_dev, int region_num,
                                           pcibus_t addr, pcibus_t size,
                                           int type)
@@ -942,15 +934,6 @@ static void pci_simple_bar_mapfunc_region(PCIDevice *pci_dev, int region_num,
                                         1);
 }
 
-void pci_register_bar_simple(PCIDevice *pci_dev, int region_num,
-                             pcibus_t size,  uint8_t attr, ram_addr_t ram_addr)
-{
-    pci_register_bar(pci_dev, region_num, size,
-                     PCI_BASE_ADDRESS_SPACE_MEMORY | attr,
-                     pci_simple_bar_mapfunc);
-    pci_dev->io_regions[region_num].ram_addr = ram_addr;
-}
-
 void pci_register_bar_region(PCIDevice *pci_dev, int region_num,
                              uint8_t attr, MemoryRegion *memory)
 {
diff --git a/hw/pci.h b/hw/pci.h
index a95e2ad..25e28b1 100644
--- a/hw/pci.h
+++ b/hw/pci.h
@@ -93,7 +93,6 @@ typedef struct PCIIORegion {
     pcibus_t filtered_size;
     uint8_t type;
     PCIMapIORegionFunc *map_func;
-    ram_addr_t ram_addr;
     MemoryRegion *memory;
     MemoryRegion *address_space;
 } PCIIORegion;
@@ -204,8 +203,6 @@ PCIDevice *pci_register_device(PCIBus *bus, const char *name,
 void pci_register_bar(PCIDevice *pci_dev, int region_num,
                             pcibus_t size, uint8_t type,
                             PCIMapIORegionFunc *map_func);
-void pci_register_bar_simple(PCIDevice *pci_dev, int region_num,
-                             pcibus_t size, uint8_t attr, ram_addr_t ram_addr);
 void pci_register_bar_region(PCIDevice *pci_dev, int region_num,
                              uint8_t attr, MemoryRegion *memory);
 pcibus_t pci_get_bar_addr(PCIDevice *pci_dev, int region_num);
-- 
1.7.5.3

  parent reply	other threads:[~2011-07-31 17:58 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-31 17:57 [Qemu-devel] [PATCH 00/39] Memory API, batch 2: PCI devices Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 01/39] pci: add API to get a BAR's mapped address Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 02/39] vmsvga: don't remember pci BAR address in callback any more Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 03/39] vga: convert vga and its derivatives to the memory API Avi Kivity
2011-07-31 18:42   ` Jan Kiszka
2011-07-31 18:46     ` Avi Kivity
2011-07-31 18:48       ` Jan Kiszka
2011-07-31 19:06         ` Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 04/39] cirrus: simplify mmio BAR access functions Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 05/39] cirrus: simplify bitblt " Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 06/39] cirrus: simplify vga window mmio " Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 07/39] vga: " Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 08/39] cirrus: simplify linear framebuffer " Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 09/39] Integrate I/O memory regions into qemu Avi Kivity
2011-08-01  0:19   ` Richard Henderson
2011-08-01  6:05     ` Avi Kivity
2011-08-01  7:42     ` [Qemu-devel] [PATCH v2 " Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 10/39] exec.c: fix initialization of system I/O memory region Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 11/39] pci: pass I/O address space to new PCI bus Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 12/39] pci: allow I/O BARs to be registered with pci_register_bar_region() Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 13/39] rtl8139: convert to memory API Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 14/39] ac97: " Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 15/39] e1000: " Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 16/39] eepro100: " Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 17/39] es1370: " Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 18/39] ide: " Avi Kivity
2011-08-01 19:22   ` Richard Henderson
2011-08-02 12:48     ` Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 19/39] ivshmem: " Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 20/39] virtio-pci: " Avi Kivity
2011-08-01  8:26   ` Michael S. Tsirkin
2011-08-01  9:35     ` Avi Kivity
2011-08-01 10:23       ` Michael S. Tsirkin
2011-08-01 20:24         ` Anthony Liguori
2011-08-03 15:16         ` Michael S. Tsirkin
2011-08-03 15:23           ` Avi Kivity
2011-08-03 15:38             ` Michael S. Tsirkin
2011-08-01 19:53       ` Michael S. Tsirkin
2011-08-02  9:17         ` Avi Kivity
2011-08-02  9:34           ` Michael S. Tsirkin
2011-08-02 12:39             ` Avi Kivity
2011-08-02 16:28           ` Gerd Hoffmann
2011-08-01 20:23     ` Anthony Liguori
2011-07-31 17:57 ` [Qemu-devel] [PATCH 21/39] ahci: " Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 22/39] intel-hda: " Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 23/39] lsi53c895a: " Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 24/39] ppc: " Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 25/39] ne2000: " Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 26/39] pcnet: " Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 27/39] i6300esb: " Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 28/39] isa-mmio: concert " Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 29/39] sun4u: convert " Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 30/39] ehci: " Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 31/39] uhci: " Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 32/39] xen-platform: " Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 33/39] msix: " Avi Kivity
2011-07-31 17:57 ` Avi Kivity [this message]
2011-07-31 17:57 ` [Qemu-devel] [PATCH 35/39] pci: convert pci rom " Avi Kivity
2011-07-31 17:57 ` [Qemu-devel] [PATCH 36/39] pci: remove pci_register_bar() Avi Kivity
2011-07-31 17:58 ` [Qemu-devel] [PATCH 37/39] pci: fold BAR mapping function into its caller Avi Kivity
2011-07-31 17:58 ` [Qemu-devel] [PATCH 38/39] pci: rename pci_register_bar_region() to pci_register_bar() Avi Kivity
2011-07-31 17:58 ` [Qemu-devel] [PATCH 39/39] pci: remove support for pre memory API BARs Avi Kivity
2011-07-31 18:02 ` [Qemu-devel] [PATCH 00/39] Memory API, batch 2: PCI devices Avi Kivity
2011-07-31 21:03   ` Anthony Liguori
2011-08-01 17:32 ` Richard Henderson
2011-08-01 21:23 ` [Qemu-devel] [RFC] Alpha system patchset updated for " Richard Henderson
2011-08-02  9:23   ` Avi Kivity
2011-08-02 15:42     ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312135082-31985-35-git-send-email-avi@redhat.com \
    --to=avi@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).