From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qny8W-00079x-CN for qemu-devel@nongnu.org; Mon, 01 Aug 2011 15:26:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qny8T-0007qz-VF for qemu-devel@nongnu.org; Mon, 01 Aug 2011 15:26:48 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:22399) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qny8T-0007qm-RZ for qemu-devel@nongnu.org; Mon, 01 Aug 2011 15:26:45 -0400 From: Anthony PERARD Date: Mon, 1 Aug 2011 20:26:21 +0100 Message-ID: <1312226782-26882-1-git-send-email-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH] xen: Avoid useless allocation in Xen case. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU-devel Cc: Anthony PERARD , Xen Devel , Alexander Graf , Stefano Stabellini The code_gen_buffer is not use by Xen and can be really big (several GB). Even if the host RAM is not used, this buffer just burn the address space of the QEMU process. So to "avoid" this allocation, the asked tb_size is set to the minimum. The other way to do that would be to not call code_gen_alloc when Xen is enabled. Signed-off-by: Anthony PERARD --- vl.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index d8c7c01..bd60a89 100644 --- a/vl.c +++ b/vl.c @@ -3106,6 +3106,14 @@ int main(int argc, char **argv, char **envp) } } + if (xen_enabled()) { + /* Allocate only the minimum amount of memory for the code_gen_buffer. + * Xen does not use it and we need the virtual address space for the + * MapCache. + */ + tb_size = 1; + } + /* init the dynamic translator */ cpu_exec_init_all(tb_size * 1024 * 1024); -- Anthony PERARD