From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44632) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoX8x-0005jj-Sp for qemu-devel@nongnu.org; Wed, 03 Aug 2011 04:49:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QoX8v-0003hw-GB for qemu-devel@nongnu.org; Wed, 03 Aug 2011 04:49:35 -0400 Received: from mail-wy0-f173.google.com ([74.125.82.173]:65424) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoX8v-0003g9-AW for qemu-devel@nongnu.org; Wed, 03 Aug 2011 04:49:33 -0400 Received: by wye20 with SMTP id 20so154364wye.4 for ; Wed, 03 Aug 2011 01:49:27 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Wed, 3 Aug 2011 10:49:04 +0200 Message-Id: <1312361359-15445-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1312361359-15445-1-git-send-email-pbonzini@redhat.com> References: <1312361359-15445-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 01/16] scsi-disk: no need to call scsi_req_data on a short read List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org In fact, if the HBA's transfer_data callback goes on with scsi_req_continue the request will be completed successfully instead of showing a failure. It can even cause a segmentation fault. An easy way to trigger it is "eject -f cd" during installation (during media test if the installer does something like that). Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index f42a5d1..814bf74 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -217,9 +217,6 @@ static int scsi_handle_rw_error(SCSIDiskReq *r, int error, int type) bdrv_mon_event(s->bs, BDRV_ACTION_STOP, is_read); vm_stop(VMSTOP_DISKFULL); } else { - if (type == SCSI_REQ_STATUS_RETRY_READ) { - scsi_req_data(&r->req, 0); - } switch (error) { case ENOMEM: scsi_command_complete(r, CHECK_CONDITION, -- 1.7.6