qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Alon Levy <alevy@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 07/11] qxl: make qxl_guest_bug take variable arguments
Date: Wed,  3 Aug 2011 12:37:42 +0200	[thread overview]
Message-ID: <1312367866-27508-8-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1312367866-27508-1-git-send-email-kraxel@redhat.com>

From: Alon Levy <alevy@redhat.com>

Signed-off-by: Alon Levy <alevy@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/qxl.c |    9 +++++++--
 hw/qxl.h |    2 +-
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/hw/qxl.c b/hw/qxl.c
index 28c8b5d..c50eaf9 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -125,13 +125,18 @@ static void qxl_reset_memslots(PCIQXLDevice *d);
 static void qxl_reset_surfaces(PCIQXLDevice *d);
 static void qxl_ring_set_dirty(PCIQXLDevice *qxl);
 
-void qxl_guest_bug(PCIQXLDevice *qxl, const char *msg)
+void qxl_guest_bug(PCIQXLDevice *qxl, const char *msg, ...)
 {
 #if SPICE_INTERFACE_QXL_MINOR >= 1
     qxl_send_events(qxl, QXL_INTERRUPT_ERROR);
 #endif
     if (qxl->guestdebug) {
-        fprintf(stderr, "qxl-%d: guest bug: %s\n", qxl->id, msg);
+        va_list ap;
+        va_start(ap, msg);
+        fprintf(stderr, "qxl-%d: guest bug: ", qxl->id);
+        vfprintf(stderr, msg, ap);
+        fprintf(stderr, "\n");
+        va_end(ap);
     }
 }
 
diff --git a/hw/qxl.h b/hw/qxl.h
index 5db9aae..32ca5a0 100644
--- a/hw/qxl.h
+++ b/hw/qxl.h
@@ -99,7 +99,7 @@ typedef struct PCIQXLDevice {
 
 /* qxl.c */
 void *qxl_phys2virt(PCIQXLDevice *qxl, QXLPHYSICAL phys, int group_id);
-void qxl_guest_bug(PCIQXLDevice *qxl, const char *msg);
+void qxl_guest_bug(PCIQXLDevice *qxl, const char *msg, ...);
 
 void qxl_spice_update_area(PCIQXLDevice *qxl, uint32_t surface_id,
                            struct QXLRect *area, struct QXLRect *dirty_rects,
-- 
1.7.1

  parent reply	other threads:[~2011-08-03 10:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-03 10:37 [Qemu-devel] [PULL] spice: async i/o for qxl Gerd Hoffmann
2011-08-03 10:37 ` [Qemu-devel] [PATCH 01/11] spice: add worker wrapper functions Gerd Hoffmann
2011-08-03 10:37 ` [Qemu-devel] [PATCH 02/11] spice: add qemu_spice_display_init_common Gerd Hoffmann
2011-08-03 10:37 ` [Qemu-devel] [PATCH 03/11] spice/qxl: move worker wrappers Gerd Hoffmann
2011-08-03 10:37 ` [Qemu-devel] [PATCH 04/11] qxl: fix surface tracking & locking Gerd Hoffmann
2011-08-03 10:37 ` [Qemu-devel] [PATCH 05/11] qxl: add io_port_to_string Gerd Hoffmann
2011-08-03 10:37 ` [Qemu-devel] [PATCH 06/11] qxl: error handling fixes and cleanups Gerd Hoffmann
2011-08-03 10:37 ` Gerd Hoffmann [this message]
2011-08-03 10:37 ` [Qemu-devel] [PATCH 08/11] qxl: only disallow specific io's in vga mode Gerd Hoffmann
2011-08-03 10:37 ` [Qemu-devel] [PATCH 09/11] qxl: async io support using new spice api Gerd Hoffmann
2011-08-03 10:37 ` [Qemu-devel] [PATCH 10/11] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3&S4 support Gerd Hoffmann
2011-08-03 10:37 ` [Qemu-devel] [PATCH 11/11] qxl: bump pci rev Gerd Hoffmann
2011-08-04 22:43 ` [Qemu-devel] [PULL] spice: async i/o for qxl Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312367866-27508-8-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=alevy@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).