qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, agraf@suse.de
Subject: [Qemu-devel] [PATCH] Permit -mem-path without sync mmu
Date: Fri,  5 Aug 2011 14:02:50 +1000	[thread overview]
Message-ID: <1312516970-26606-1-git-send-email-david@gibson.dropbear.id.au> (raw)

At present, an explicit test disallows use of -mem-path when kvm is enabled
but KVM_CAP_SYNC_MMU is not set.  In particular, this prevents the user
from using hugetlbfs to back the guest memory.

I can see no reason for this check, and when I asked about it previously,
the only theory offered was that this was a limitation of the very early
days of kvm which only happened to match the SYNC_MMU flag by accident.

This patch, therefore, removes the check.  This is of particular use to
us on POWER, where we haven't yet implement SYNC_MMU, but where backing
the guest with hugepages is possible, and in fact mandatory (for now).

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 exec.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/exec.c b/exec.c
index 476b507..041637c 100644
--- a/exec.c
+++ b/exec.c
@@ -2818,11 +2818,6 @@ static void *file_ram_alloc(RAMBlock *block,
         return NULL;
     }
 
-    if (kvm_enabled() && !kvm_has_sync_mmu()) {
-        fprintf(stderr, "host lacks kvm mmu notifiers, -mem-path unsupported\n");
-        return NULL;
-    }
-
     if (asprintf(&filename, "%s/qemu_back_mem.XXXXXX", path) == -1) {
         return NULL;
     }
-- 
1.7.5.4

             reply	other threads:[~2011-08-05  4:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-05  4:02 David Gibson [this message]
2011-08-05  6:16 ` [Qemu-devel] [PATCH] Permit -mem-path without sync mmu Jan Kiszka
2011-08-05 15:30   ` Marcelo Tosatti
2011-08-08  6:03     ` David Gibson
2011-08-08  8:24       ` Avi Kivity
2011-08-10  5:10         ` David Gibson
2011-08-10  9:01           ` Avi Kivity
2011-08-11  6:09             ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312516970-26606-1-git-send-email-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).