From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QqHT1-0007AA-CN for qemu-devel@nongnu.org; Mon, 08 Aug 2011 00:29:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QqHSz-0006Mv-3X for qemu-devel@nongnu.org; Mon, 08 Aug 2011 00:29:31 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:46983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QqHJ0-0003kP-Vg for qemu-devel@nongnu.org; Mon, 08 Aug 2011 00:19:11 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e36.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p784CRpx020161 for ; Sun, 7 Aug 2011 22:12:27 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id p784IlbJ161798 for ; Sun, 7 Aug 2011 22:18:47 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p77MIkDI015371 for ; Sun, 7 Aug 2011 16:18:47 -0600 From: Zhi Yong Wu Date: Mon, 8 Aug 2011 12:15:32 +0800 Message-Id: <1312776932-15081-1-git-send-email-wuzhy@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH] qdev: Remove some non-run codes in qdev_walk_children(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, Zhi Yong Wu , armbru@redhat.com, zwu.kernel@gmail.com, ryanh@us.ibm.com, luowenj@cn.ibm.com As you have known, qdev_reset_one() forever return a ZERO value to its caller, so some branches can not be forever covered in qdev_walk_children(). I thought that the return value for dev->info->reset(dev) can be returned, but dev->info->reset(dev) is referring to a function with void type. Signed-off-by: Zhi Yong Wu --- hw/qdev.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 292b52f..cbc5e02 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -513,10 +513,7 @@ int qdev_walk_children(DeviceState *dev, qdev_walkerfn *devfn, int err; if (devfn) { - err = devfn(dev, opaque); - if (err) { - return err; - } + devfn(dev, opaque); } QLIST_FOREACH(bus, &dev->child_bus, sibling) { -- 1.7.2.3