From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43605) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QqTGI-0007ab-2C for qemu-devel@nongnu.org; Mon, 08 Aug 2011 13:05:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QqTGG-0001nK-OI for qemu-devel@nongnu.org; Mon, 08 Aug 2011 13:05:09 -0400 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:36845) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QqTGG-0001le-0V for qemu-devel@nongnu.org; Mon, 08 Aug 2011 13:05:08 -0400 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [202.81.31.245]) by e23smtp04.au.ibm.com (8.14.4/8.13.1) with ESMTP id p78GwgKp005970 for ; Tue, 9 Aug 2011 02:58:42 +1000 Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p78H56Gi1781826 for ; Tue, 9 Aug 2011 03:05:06 +1000 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p78H55cp030081 for ; Tue, 9 Aug 2011 03:05:06 +1000 From: "Aneesh Kumar K.V" Date: Mon, 8 Aug 2011 22:34:09 +0530 Message-Id: <1312823054-28331-22-git-send-email-aneesh.kumar@linux.vnet.ibm.com> In-Reply-To: <1312823054-28331-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> References: <1312823054-28331-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH -V4 21/26] hw/9pfs: Update v9fs_mknod to use coroutines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, "Aneesh Kumar K.V" Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p.c | 88 +++++++++++++++++--------------------------------- 1 files changed, 30 insertions(+), 58 deletions(-) diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index 897f541..fbed376 100644 --- a/hw/9pfs/virtio-9p.c +++ b/hw/9pfs/virtio-9p.c @@ -3019,77 +3019,49 @@ out: return; } -static void v9fs_mknod_post_lstat(V9fsState *s, V9fsMkState *vs, int err) -{ - if (err == -1) { - err = -errno; - goto out; - } - - stat_to_qid(&vs->stbuf, &vs->qid); - vs->offset += pdu_marshal(vs->pdu, vs->offset, "Q", &vs->qid); - err = vs->offset; -out: - complete_pdu(s, vs->pdu, err); - v9fs_string_free(&vs->fullname); - v9fs_string_free(&vs->name); - qemu_free(vs); -} - -static void v9fs_mknod_post_mknod(V9fsState *s, V9fsMkState *vs, int err) -{ - if (err == -1) { - err = -errno; - goto out; - } - - err = v9fs_do_lstat(s, &vs->fullname, &vs->stbuf); - v9fs_mknod_post_lstat(s, vs, err); - return; -out: - complete_pdu(s, vs->pdu, err); - v9fs_string_free(&vs->fullname); - v9fs_string_free(&vs->name); - qemu_free(vs); -} - static void v9fs_mknod(void *opaque) { - V9fsPDU *pdu = opaque; - V9fsState *s = pdu->s; + + int mode; + gid_t gid; int32_t fid; - V9fsMkState *vs; + V9fsQID qid; int err = 0; - V9fsFidState *fidp; - gid_t gid; - int mode; int major, minor; + size_t offset = 7; + V9fsString name; + struct stat stbuf; + V9fsString fullname; + V9fsFidState *fidp; + V9fsPDU *pdu = opaque; + V9fsState *s = pdu->s; - vs = qemu_malloc(sizeof(*vs)); - vs->pdu = pdu; - vs->offset = 7; - - v9fs_string_init(&vs->fullname); - pdu_unmarshal(vs->pdu, vs->offset, "dsdddd", &fid, &vs->name, &mode, - &major, &minor, &gid); + v9fs_string_init(&fullname); + pdu_unmarshal(pdu, offset, "dsdddd", &fid, &name, &mode, + &major, &minor, &gid); fidp = lookup_fid(s, fid); if (fidp == NULL) { err = -ENOENT; goto out; } - - v9fs_string_sprintf(&vs->fullname, "%s/%s", fidp->path.data, vs->name.data); - err = v9fs_do_mknod(s, vs->fullname.data, mode, makedev(major, minor), - fidp->uid, gid); - v9fs_mknod_post_mknod(s, vs, err); - return; - + v9fs_string_sprintf(&fullname, "%s/%s", fidp->path.data, name.data); + err = v9fs_co_mknod(s, &fullname, fidp->uid, gid, + makedev(major, minor), mode); + if (err < 0) { + goto out; + } + err = v9fs_co_lstat(s, &fullname, &stbuf); + if (err < 0) { + goto out; + } + stat_to_qid(&stbuf, &qid); + err = offset; + err += pdu_marshal(pdu, offset, "Q", &qid); out: - complete_pdu(s, vs->pdu, err); - v9fs_string_free(&vs->fullname); - v9fs_string_free(&vs->name); - qemu_free(vs); + complete_pdu(s, pdu, err); + v9fs_string_free(&fullname); + v9fs_string_free(&name); } /* -- 1.7.4.1