qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com,
	"Venkateswararao Jujjuri (JV)" <jvrao@linux.vnet.ibm.com>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH -V4 04/26] [virtio-9p] Remove post functions for v9fs_readlink.
Date: Mon,  8 Aug 2011 22:33:52 +0530	[thread overview]
Message-ID: <1312823054-28331-5-git-send-email-aneesh.kumar@linux.vnet.ibm.com> (raw)
In-Reply-To: <1312823054-28331-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>

From: Venkateswararao Jujjuri (JV) <jvrao@linux.vnet.ibm.com>

In the process of preparation for coroutine threads, remove all post functions
and make the function more readable.

Signed-off-by: Venkateswararao Jujjuri "<jvrao@linux.vnet.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
 hw/9pfs/virtio-9p.c |   29 +++++++++--------------------
 1 files changed, 9 insertions(+), 20 deletions(-)

diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
index 113ce1e..fa83058 100644
--- a/hw/9pfs/virtio-9p.c
+++ b/hw/9pfs/virtio-9p.c
@@ -1949,13 +1949,13 @@ static void v9fs_read_post_seekdir(V9fsState *s, V9fsReadState *vs, ssize_t err)
     if (err) {
         goto out;
     }
-    v9fs_stat_free(&vs->v9stat);
-    v9fs_string_free(&vs->name);
     vs->offset += pdu_marshal(vs->pdu, vs->offset, "d", vs->count);
     vs->offset += vs->count;
     err = vs->offset;
 out:
     complete_pdu(s, vs->pdu, err);
+    v9fs_stat_free(&vs->v9stat);
+    v9fs_string_free(&vs->name);
     qemu_free(vs);
     return;
 }
@@ -3582,21 +3582,6 @@ out:
     qemu_free(vs);
 }
 
-static void v9fs_readlink_post_readlink(V9fsState *s, V9fsReadLinkState *vs,
-                                                    int err)
-{
-    if (err < 0) {
-        err = -errno;
-        goto out;
-    }
-    vs->offset += pdu_marshal(vs->pdu, vs->offset, "s", &vs->target);
-    err = vs->offset;
-out:
-    complete_pdu(s, vs->pdu, err);
-    v9fs_string_free(&vs->target);
-    qemu_free(vs);
-}
-
 static void v9fs_readlink(void *opaque)
 {
     V9fsPDU *pdu = opaque;
@@ -3611,7 +3596,6 @@ static void v9fs_readlink(void *opaque)
     vs->offset = 7;
 
     pdu_unmarshal(vs->pdu, vs->offset, "d", &fid);
-
     fidp = lookup_fid(s, fid);
     if (fidp == NULL) {
         err = -ENOENT;
@@ -3620,10 +3604,15 @@ static void v9fs_readlink(void *opaque)
 
     v9fs_string_init(&vs->target);
     err = v9fs_do_readlink(s, &fidp->path, &vs->target);
-    v9fs_readlink_post_readlink(s, vs, err);
-    return;
+    if (err < 0) {
+        err = -errno;
+        goto out;
+    }
+    vs->offset += pdu_marshal(vs->pdu, vs->offset, "s", &vs->target);
+    err = vs->offset;
 out:
     complete_pdu(s, vs->pdu, err);
+    v9fs_string_free(&vs->target);
     qemu_free(vs);
 }
 
-- 
1.7.4.1

  parent reply	other threads:[~2011-08-08 17:04 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-08 17:03 [Qemu-devel] [PATCHSET 1] VirtFS coroutine changes Aneesh Kumar K.V
2011-08-08 17:03 ` [Qemu-devel] [PATCH -V4 01/26] coroutine: add gthread dependency Aneesh Kumar K.V
2011-08-19 10:48   ` TeLeMan
2011-08-08 17:03 ` [Qemu-devel] [PATCH -V4 02/26] [virtio-9p] Add infrastructure to support glib threads and coroutines Aneesh Kumar K.V
2011-08-08 17:03 ` [Qemu-devel] [PATCH -V4 03/26] [virtio-9p] Change all pdu handlers to coroutines Aneesh Kumar K.V
2011-08-08 17:03 ` Aneesh Kumar K.V [this message]
2011-08-08 17:03 ` [Qemu-devel] [PATCH -V4 05/26] [virtio-9p] clean up v9fs_readlink Aneesh Kumar K.V
2011-08-08 17:03 ` [Qemu-devel] [PATCH -V4 06/26] [virtio-9p] coroutines for readlink Aneesh Kumar K.V
2011-08-08 17:03 ` [Qemu-devel] [PATCH -V4 07/26] [virtio-9p] Remove post functions for v9fs_mkdir Aneesh Kumar K.V
2011-08-08 17:03 ` [Qemu-devel] [PATCH -V4 08/26] [virtio-9p] clean up v9fs_mkdir Aneesh Kumar K.V
2011-08-08 17:03 ` [Qemu-devel] [PATCH -V4 09/26] hw/9pfs: Add yield support for readdir related coroutines Aneesh Kumar K.V
2011-08-08 17:03 ` [Qemu-devel] [PATCH -V4 10/26] hw/9pfs: Update v9fs_readdir to use coroutines Aneesh Kumar K.V
2011-08-08 17:03 ` [Qemu-devel] [PATCH -V4 11/26] hw/9pfs: Add yield support to statfs coroutine Aneesh Kumar K.V
2011-08-08 17:04 ` [Qemu-devel] [PATCH -V4 12/26] hw/9pfs: Update v9fs_statfs to use coroutines Aneesh Kumar K.V
2011-08-08 17:04 ` [Qemu-devel] [PATCH -V4 13/26] hw/9pfs: Add yield support to lstat coroutine Aneesh Kumar K.V
2011-08-08 17:04 ` [Qemu-devel] [PATCH -V4 14/26] hw/9pfs: Update v9fs_getattr to use coroutines Aneesh Kumar K.V
2011-08-08 17:04 ` [Qemu-devel] [PATCH -V4 15/26] hw/9pfs: Add yield support to setattr related coroutines Aneesh Kumar K.V
2011-08-08 17:04 ` [Qemu-devel] [PATCH -V4 16/26] hw/9pfs: Update v9fs_setattr to use coroutines Aneesh Kumar K.V
2011-08-08 17:04 ` [Qemu-devel] [PATCH -V4 17/26] hw/9pfs: Add yield support to xattr related coroutine Aneesh Kumar K.V
2011-08-08 17:04 ` [Qemu-devel] [PATCH -V4 18/26] hw/9pfs: Update v9fs_xattrwalk to coroutines Aneesh Kumar K.V
2011-08-08 17:04 ` [Qemu-devel] [PATCH -V4 19/26] hw/9pfs: Update v9fs_xattrcreate to use coroutines Aneesh Kumar K.V
2011-08-08 17:04 ` [Qemu-devel] [PATCH -V4 20/26] hw/9pfs: Add yield support to mknod coroutine Aneesh Kumar K.V
2011-08-08 17:04 ` [Qemu-devel] [PATCH -V4 21/26] hw/9pfs: Update v9fs_mknod to use coroutines Aneesh Kumar K.V
2011-08-08 17:04 ` [Qemu-devel] [PATCH -V4 22/26] [virtio-9p] coroutine and threading for mkdir Aneesh Kumar K.V
2011-08-08 17:04 ` [Qemu-devel] [PATCH -V4 23/26] [virtio-9p] Remove post functions for v9fs_remove Aneesh Kumar K.V
2011-08-08 17:04 ` [Qemu-devel] [PATCH -V4 24/26] [virtio-9p] clean up v9fs_remove Aneesh Kumar K.V
2011-08-08 17:04 ` [Qemu-devel] [PATCH -V4 25/26] [virtio-9p] coroutine and threading for remove/unlink Aneesh Kumar K.V
2011-08-08 17:04 ` [Qemu-devel] [PATCH -V4 26/26] hw/9pfs: Add yeild support to rename coroutine Aneesh Kumar K.V
2011-08-11 16:15 ` [Qemu-devel] [PULL] [PATCHSET 1] VirtFS coroutine changes Aneesh Kumar K.V
2011-08-12 13:04   ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312823054-28331-5-git-send-email-aneesh.kumar@linux.vnet.ibm.com \
    --to=aneesh.kumar@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=jvrao@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).