qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH -V4 10/28] hw/9pfs: Update v9fs_stat to use coroutines
Date: Mon,  8 Aug 2011 22:36:37 +0530	[thread overview]
Message-ID: <1312823215-28675-11-git-send-email-aneesh.kumar@linux.vnet.ibm.com> (raw)
In-Reply-To: <1312823215-28675-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
 hw/9pfs/virtio-9p.c |   61 +++++++++++++++++---------------------------------
 1 files changed, 21 insertions(+), 40 deletions(-)

diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
index 43f5503..cc28161 100644
--- a/hw/9pfs/virtio-9p.c
+++ b/hw/9pfs/virtio-9p.c
@@ -1169,56 +1169,37 @@ out:
     v9fs_string_free(&aname);
 }
 
-static void v9fs_stat_post_lstat(V9fsState *s, V9fsStatState *vs, int err)
-{
-    if (err == -1) {
-        err = -errno;
-        goto out;
-    }
-
-    err = stat_to_v9stat(s, &vs->fidp->path, &vs->stbuf, &vs->v9stat);
-    if (err) {
-        goto out;
-    }
-    vs->offset += pdu_marshal(vs->pdu, vs->offset, "wS", 0, &vs->v9stat);
-    err = vs->offset;
-
-out:
-    complete_pdu(s, vs->pdu, err);
-    v9fs_stat_free(&vs->v9stat);
-    qemu_free(vs);
-}
-
 static void v9fs_stat(void *opaque)
 {
-    V9fsPDU *pdu = opaque;
-    V9fsState *s = pdu->s;
     int32_t fid;
-    V9fsStatState *vs;
+    V9fsStat v9stat;
     ssize_t err = 0;
+    size_t offset = 7;
+    struct stat stbuf;
+    V9fsFidState *fidp;
+    V9fsPDU *pdu = opaque;
+    V9fsState *s = pdu->s;
 
-    vs = qemu_malloc(sizeof(*vs));
-    vs->pdu = pdu;
-    vs->offset = 7;
-
-    memset(&vs->v9stat, 0, sizeof(vs->v9stat));
-
-    pdu_unmarshal(vs->pdu, vs->offset, "d", &fid);
+    pdu_unmarshal(pdu, offset, "d", &fid);
 
-    vs->fidp = lookup_fid(s, fid);
-    if (vs->fidp == NULL) {
+    fidp = lookup_fid(s, fid);
+    if (fidp == NULL) {
         err = -ENOENT;
         goto out;
     }
-
-    err = v9fs_do_lstat(s, &vs->fidp->path, &vs->stbuf);
-    v9fs_stat_post_lstat(s, vs, err);
-    return;
-
+    err = v9fs_co_lstat(s, &fidp->path, &stbuf);
+    if (err < 0) {
+        goto out;
+    }
+    err = stat_to_v9stat(s, &fidp->path, &stbuf, &v9stat);
+    if (err < 0) {
+        goto out;
+    }
+    offset += pdu_marshal(pdu, offset, "wS", 0, &v9stat);
+    err = offset;
+    v9fs_stat_free(&v9stat);
 out:
-    complete_pdu(s, vs->pdu, err);
-    v9fs_stat_free(&vs->v9stat);
-    qemu_free(vs);
+    complete_pdu(s, pdu, err);
 }
 
 static void v9fs_getattr(void *opaque)
-- 
1.7.4.1

  parent reply	other threads:[~2011-08-08 17:08 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-08 17:06 [Qemu-devel] [PATCHSET 2] VirtFS coroutine changes Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 01/28] hw/9pfs: Update vfs_rename to use coroutines Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 02/28] hw/9pfs: Add yeild support for fstat coroutine Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 03/28] hw/9pfs: Update v9fs_lock to use coroutines Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 04/28] hw/9pfs: Update v9fs_getlock " Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 05/28] hw/9pfs: Add yield support for open and opendir coroutine Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 06/28] hw/9pfs: Update v9fs_open to use coroutines Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 07/28] [virtio-9p] Remove post functions for v9fs_lcreate Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 08/28] [virtio-9p] clean up v9fs_lcreate Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 09/28] [virtio-9p] coroutine and threading for open2 Aneesh Kumar K.V
2011-08-08 17:06 ` Aneesh Kumar K.V [this message]
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 11/28] hw/9pfs: Update v9fs_walk to use coroutines Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 12/28] hw/9pfs: Add yeild support for clunk related coroutine Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 13/28] hw/9pfs: Update v9fs_clunk to use coroutines Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 14/28] hw/9pfs: Add yield support for fsync coroutine Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 15/28] hw/9pfs: Update v9fs_fsync to use coroutines Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 16/28] [virtio-9p] Remove post functions for v9fs_create Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 17/28] [virtio-9p] clean up v9fs_create Rearrange the code Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 18/28] [virtio-9p] Remove post functions for v9fs_symlink Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 19/28] [virtio-9p] clean up v9fs_symlink Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 20/28] [virtio-9p] coroutine and threading for v9fs_do_symlink Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 21/28] [virtio-9p] coroutine and threading for v9fs_do_link Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 22/28] hw/9pfs: Add yield support for pwritev coroutine Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 23/28] hw/9pfs: Update v9fs_write to use coroutines Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 24/28] hw/9pfs: Update v9fs_wstat " Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 25/28] hw/9pfs: Update v9fs_attach " Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 26/28] hw/9pfs: Add yield support for preadv coroutine Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 27/28] hw/9pfs: Update v9fs_read to use coroutines Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 28/28] use readdir_r instead of readdir for reentrancy Aneesh Kumar K.V
2011-08-11 15:47 ` [Qemu-devel] [PATCHSET 2] VirtFS coroutine changes Aneesh Kumar K.V
2011-08-16  8:03   ` [Qemu-devel] [PULL] " Aneesh Kumar K.V
2011-08-21 23:36     ` Anthony Liguori
2011-08-22  5:52       ` Aneesh Kumar K.V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312823215-28675-11-git-send-email-aneesh.kumar@linux.vnet.ibm.com \
    --to=aneesh.kumar@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).