From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH -V4 13/28] hw/9pfs: Update v9fs_clunk to use coroutines
Date: Mon, 8 Aug 2011 22:36:40 +0530 [thread overview]
Message-ID: <1312823215-28675-14-git-send-email-aneesh.kumar@linux.vnet.ibm.com> (raw)
In-Reply-To: <1312823215-28675-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
hw/9pfs/virtio-9p.c | 44 +++++++-------------------------------------
1 files changed, 7 insertions(+), 37 deletions(-)
diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
index acc04a5..206153d 100644
--- a/hw/9pfs/virtio-9p.c
+++ b/hw/9pfs/virtio-9p.c
@@ -82,16 +82,6 @@ static int v9fs_do_lstat(V9fsState *s, V9fsString *path, struct stat *stbuf)
return s->ops->lstat(&s->ctx, path->data, stbuf);
}
-static int v9fs_do_close(V9fsState *s, int fd)
-{
- return s->ops->close(&s->ctx, fd);
-}
-
-static int v9fs_do_closedir(V9fsState *s, DIR *dir)
-{
- return s->ops->closedir(&s->ctx, dir);
-}
-
static DIR *v9fs_do_opendir(V9fsState *s, V9fsString *path)
{
return s->ops->opendir(&s->ctx, path->data);
@@ -192,22 +182,6 @@ static int v9fs_do_fsync(V9fsState *s, int fd, int datasync)
return s->ops->fsync(&s->ctx, fd, datasync);
}
-static int v9fs_do_lsetxattr(V9fsState *s, V9fsString *path,
- V9fsString *xattr_name,
- void *value, size_t size, int flags)
-{
- return s->ops->lsetxattr(&s->ctx, path->data,
- xattr_name->data, value, size, flags);
-}
-
-static int v9fs_do_lremovexattr(V9fsState *s, V9fsString *path,
- V9fsString *xattr_name)
-{
- return s->ops->lremovexattr(&s->ctx, path->data,
- xattr_name->data);
-}
-
-
static void v9fs_string_init(V9fsString *str)
{
str->data = NULL;
@@ -414,12 +388,12 @@ static int v9fs_xattr_fid_clunk(V9fsState *s, V9fsFidState *fidp)
goto free_out;
}
if (fidp->fs.xattr.len) {
- retval = v9fs_do_lsetxattr(s, &fidp->path, &fidp->fs.xattr.name,
+ retval = v9fs_co_lsetxattr(s, &fidp->path, &fidp->fs.xattr.name,
fidp->fs.xattr.value,
fidp->fs.xattr.len,
fidp->fs.xattr.flags);
} else {
- retval = v9fs_do_lremovexattr(s, &fidp->path, &fidp->fs.xattr.name);
+ retval = v9fs_co_lremovexattr(s, &fidp->path, &fidp->fs.xattr.name);
}
free_out:
v9fs_string_free(&fidp->fs.xattr.name);
@@ -449,15 +423,14 @@ static int free_fid(V9fsState *s, int32_t fid)
*fidpp = fidp->next;
if (fidp->fid_type == P9_FID_FILE) {
- v9fs_do_close(s, fidp->fs.fd);
+ retval = v9fs_co_close(s, fidp);
} else if (fidp->fid_type == P9_FID_DIR) {
- v9fs_do_closedir(s, fidp->fs.dir);
+ retval = v9fs_co_closedir(s, fidp);
} else if (fidp->fid_type == P9_FID_XATTR) {
retval = v9fs_xattr_fid_clunk(s, fidp);
}
v9fs_string_free(&fidp->path);
qemu_free(fidp);
-
return retval;
}
@@ -1591,20 +1564,17 @@ static void v9fs_fsync(void *opaque)
static void v9fs_clunk(void *opaque)
{
- V9fsPDU *pdu = opaque;
- V9fsState *s = pdu->s;
+ int err;
int32_t fid;
size_t offset = 7;
- int err;
+ V9fsPDU *pdu = opaque;
+ V9fsState *s = pdu->s;
pdu_unmarshal(pdu, offset, "d", &fid);
-
err = free_fid(s, fid);
if (err < 0) {
goto out;
}
-
- offset = 7;
err = offset;
out:
complete_pdu(s, pdu, err);
--
1.7.4.1
next prev parent reply other threads:[~2011-08-08 17:08 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 17:06 [Qemu-devel] [PATCHSET 2] VirtFS coroutine changes Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 01/28] hw/9pfs: Update vfs_rename to use coroutines Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 02/28] hw/9pfs: Add yeild support for fstat coroutine Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 03/28] hw/9pfs: Update v9fs_lock to use coroutines Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 04/28] hw/9pfs: Update v9fs_getlock " Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 05/28] hw/9pfs: Add yield support for open and opendir coroutine Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 06/28] hw/9pfs: Update v9fs_open to use coroutines Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 07/28] [virtio-9p] Remove post functions for v9fs_lcreate Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 08/28] [virtio-9p] clean up v9fs_lcreate Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 09/28] [virtio-9p] coroutine and threading for open2 Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 10/28] hw/9pfs: Update v9fs_stat to use coroutines Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 11/28] hw/9pfs: Update v9fs_walk " Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 12/28] hw/9pfs: Add yeild support for clunk related coroutine Aneesh Kumar K.V
2011-08-08 17:06 ` Aneesh Kumar K.V [this message]
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 14/28] hw/9pfs: Add yield support for fsync coroutine Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 15/28] hw/9pfs: Update v9fs_fsync to use coroutines Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 16/28] [virtio-9p] Remove post functions for v9fs_create Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 17/28] [virtio-9p] clean up v9fs_create Rearrange the code Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 18/28] [virtio-9p] Remove post functions for v9fs_symlink Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 19/28] [virtio-9p] clean up v9fs_symlink Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 20/28] [virtio-9p] coroutine and threading for v9fs_do_symlink Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 21/28] [virtio-9p] coroutine and threading for v9fs_do_link Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 22/28] hw/9pfs: Add yield support for pwritev coroutine Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 23/28] hw/9pfs: Update v9fs_write to use coroutines Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 24/28] hw/9pfs: Update v9fs_wstat " Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 25/28] hw/9pfs: Update v9fs_attach " Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 26/28] hw/9pfs: Add yield support for preadv coroutine Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 27/28] hw/9pfs: Update v9fs_read to use coroutines Aneesh Kumar K.V
2011-08-08 17:06 ` [Qemu-devel] [PATCH -V4 28/28] use readdir_r instead of readdir for reentrancy Aneesh Kumar K.V
2011-08-11 15:47 ` [Qemu-devel] [PATCHSET 2] VirtFS coroutine changes Aneesh Kumar K.V
2011-08-16 8:03 ` [Qemu-devel] [PULL] " Aneesh Kumar K.V
2011-08-21 23:36 ` Anthony Liguori
2011-08-22 5:52 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312823215-28675-14-git-send-email-aneesh.kumar@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).