* [Qemu-devel] [PATCH STABLE] qapi: fix build issue due to missing newline in generated header
@ 2011-08-10 18:10 Michael Roth
2011-08-12 13:45 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Michael Roth @ 2011-08-10 18:10 UTC (permalink / raw)
To: qemu-devel; +Cc: aliguori, mdroth
Fixes a build issue on RHEL5, and potentially other distros, where gcc
will generate an error due to us not writing a trailing "\n" when
generating *qmp-commands.h
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
scripts/qapi-commands.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py
index 9ad4c54..bf61740 100644
--- a/scripts/qapi-commands.py
+++ b/scripts/qapi-commands.py
@@ -375,7 +375,7 @@ if dispatch_type == "sync":
ret = gen_marshal_input(cmd['command'], arglist, ret_type) + "\n"
fdef.write(ret)
- fdecl.write("\n#endif");
+ fdecl.write("\n#endif\n");
ret = gen_registry(commands)
fdef.write(ret)
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH STABLE] qapi: fix build issue due to missing newline in generated header
2011-08-10 18:10 [Qemu-devel] [PATCH STABLE] qapi: fix build issue due to missing newline in generated header Michael Roth
@ 2011-08-12 13:45 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2011-08-12 13:45 UTC (permalink / raw)
To: Michael Roth; +Cc: qemu-devel
On 08/10/2011 01:10 PM, Michael Roth wrote:
> Fixes a build issue on RHEL5, and potentially other distros, where gcc
> will generate an error due to us not writing a trailing "\n" when
> generating *qmp-commands.h
>
> Signed-off-by: Michael Roth<mdroth@linux.vnet.ibm.com>
Applied to master. Thanks.
Regards,
Anthony Liguori
> ---
> scripts/qapi-commands.py | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py
> index 9ad4c54..bf61740 100644
> --- a/scripts/qapi-commands.py
> +++ b/scripts/qapi-commands.py
> @@ -375,7 +375,7 @@ if dispatch_type == "sync":
> ret = gen_marshal_input(cmd['command'], arglist, ret_type) + "\n"
> fdef.write(ret)
>
> - fdecl.write("\n#endif");
> + fdecl.write("\n#endif\n");
> ret = gen_registry(commands)
> fdef.write(ret)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-12 13:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-10 18:10 [Qemu-devel] [PATCH STABLE] qapi: fix build issue due to missing newline in generated header Michael Roth
2011-08-12 13:45 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).